Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Cast SparseTensor and FixedShapeSparseTensor to Python #3010

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

sagiahrac
Copy link
Contributor

Addresses: #3009

This PR enables casting of SparseTensor and FixedShapeSparseTensor to Python, allowing iteration over Daft DataFrames with sparse tensor columns without converting to dense formats.

@github-actions github-actions bot added the enhancement New feature or request label Oct 7, 2024
Copy link

codspeed-hq bot commented Oct 7, 2024

CodSpeed Performance Report

Merging #3010 will not alter performance

Comparing sagiahrac:sage-cast-sparse-to-py (1e81dd5) with main (648b804)

Summary

✅ 17 untouched benchmarks

@sagiahrac sagiahrac marked this pull request as draft October 7, 2024 13:01
@sagiahrac sagiahrac marked this pull request as ready for review October 7, 2024 13:43
@jaychia jaychia requested a review from colin-ho October 8, 2024 14:52
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sagiahrac !

@colin-ho colin-ho merged commit c2397bf into Eventual-Inc:main Oct 8, 2024
36 checks passed
@sagiahrac sagiahrac deleted the sage-cast-sparse-to-py branch October 8, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants