Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix write_deltalake add action file path prefix #3053

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

kevinzwang
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Oct 15, 2024
@kevinzwang kevinzwang enabled auto-merge (squash) October 15, 2024 23:21
Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #3053 will not alter performance

Comparing kevin/deltalake-roundtrip (f786e0e) with main (e93dd94)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (e93dd94) to head (f786e0e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
daft/table/table_io.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   78.35%   78.34%   -0.01%     
==========================================
  Files         610      610              
  Lines       72023    72022       -1     
==========================================
- Hits        56431    56427       -4     
- Misses      15592    15595       +3     
Files with missing lines Coverage Δ
src/daft-parquet/src/lib.rs 50.00% <ø> (ø)
daft/table/table_io.py 85.75% <0.00%> (-0.22%) ⬇️

... and 3 files with indirect coverage changes

@kevinzwang kevinzwang enabled auto-merge (squash) October 15, 2024 23:55
@kevinzwang kevinzwang merged commit 1aaf3cf into main Oct 16, 2024
40 checks passed
@kevinzwang kevinzwang deleted the kevin/deltalake-roundtrip branch October 16, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant