Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: joins with duplicate column names and qualified table expansion #3074

Merged

Conversation

@universalmind303 universalmind303 changed the title [FIX]: joins with duplicate column names and qualified table expansion [BUG]: joins with duplicate column names and qualified table expansion Oct 18, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 18, 2024
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #3074 will not alter performance

Comparing universalmind303:joins_with_prefix (49b342d) with main (5795adc)

Summary

✅ 17 untouched benchmarks

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but I have some questions about the logic in src/daft-sql/src/planner.rs to confirm my understanding. Also down to hop on Zoom to chat about it

src/daft-plan/src/logical_plan.rs Outdated Show resolved Hide resolved
src/daft-sql/src/planner.rs Show resolved Hide resolved
src/daft-sql/src/planner.rs Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) October 18, 2024 22:34
@universalmind303 universalmind303 merged commit b04e56f into Eventual-Inc:main Oct 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants