Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable unpivot for swordfish #3078

Merged
merged 4 commits into from
Oct 22, 2024
Merged

[FEAT] Enable unpivot for swordfish #3078

merged 4 commits into from
Oct 22, 2024

Conversation

colin-ho
Copy link
Contributor

Adds unpivot as an intermediate operator. Unskips all the unpivot tests

@github-actions github-actions bot added the enhancement New feature or request label Oct 18, 2024
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #3078 will not alter performance

Comparing colin/unpivot (dddc568) with main (4a8244b)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (4a8244b) to head (dddc568).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3078      +/-   ##
==========================================
+ Coverage   78.49%   78.51%   +0.01%     
==========================================
  Files         613      614       +1     
  Lines       72761    72821      +60     
==========================================
+ Hits        57111    57172      +61     
+ Misses      15650    15649       -1     
Files with missing lines Coverage Δ
...ft-local-execution/src/intermediate_ops/unpivot.rs 100.00% <100.00%> (ø)
src/daft-local-execution/src/pipeline.rs 92.72% <100.00%> (+0.38%) ⬆️
src/daft-physical-plan/src/local_plan.rs 89.20% <100.00%> (+1.11%) ⬆️
src/daft-physical-plan/src/translate.rs 94.73% <100.00%> (+0.42%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@colin-ho colin-ho merged commit 31d5412 into main Oct 22, 2024
42 checks passed
@colin-ho colin-ho deleted the colin/unpivot branch October 22, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants