Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Disable Linux SSL CERT override #3098

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Oct 21, 2024

fixes: #3097

Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #3098 will not alter performance

Comparing sammy/disable-ssl-override (4074d06) with main (2f09cae)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (2f09cae) to head (4074d06).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3098      +/-   ##
==========================================
+ Coverage   78.36%   78.46%   +0.10%     
==========================================
  Files         612      612              
  Lines       72718    72684      -34     
==========================================
+ Hits        56985    57032      +47     
+ Misses      15733    15652      -81     
Files with missing lines Coverage Δ
daft/io/__init__.py 100.00% <ø> (+4.16%) ⬆️

... and 8 files with indirect coverage changes

@samster25 samster25 merged commit 9338e2e into main Oct 21, 2024
44 checks passed
@samster25 samster25 deleted the sammy/disable-ssl-override branch October 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL_CERT_FILE environment variable is set when importing daft
1 participant