Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix type widening for rem #3131

Merged
merged 4 commits into from
Oct 28, 2024
Merged

[BUG] fix type widening for rem #3131

merged 4 commits into from
Oct 28, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Oct 26, 2024

  • Fixes an issue where the resultant type of UInt64 % Int32 would be a Float64.
  • This would lead to problems when performing a mod on the result of a hash

@github-actions github-actions bot added the bug Something isn't working label Oct 26, 2024
Copy link

codspeed-hq bot commented Oct 26, 2024

CodSpeed Performance Report

Merging #3131 will not alter performance

Comparing sammy/rem-type-widening (f6fff6a) with main (915467b)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (915467b) to head (f6fff6a).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
+ Coverage   78.30%   78.68%   +0.38%     
==========================================
  Files         620      621       +1     
  Lines       74691    74284     -407     
==========================================
- Hits        58484    58449      -35     
+ Misses      16207    15835     -372     
Files with missing lines Coverage Δ
daft/datatype.py 91.89% <100.00%> (+0.04%) ⬆️
src/daft-core/src/datatypes/infer_datatype.rs 88.44% <100.00%> (+2.05%) ⬆️
src/daft-core/src/series/ops/arithmetic.rs 84.29% <ø> (ø)
src/daft-schema/src/python/datatype.rs 81.22% <100.00%> (+0.19%) ⬆️

... and 17 files with indirect coverage changes

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@samster25 samster25 merged commit a112523 into main Oct 28, 2024
42 checks passed
@samster25 samster25 deleted the sammy/rem-type-widening branch October 28, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants