[FEAT]: Sql common table expressions (CTE's) #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3137 will not alter performanceComparing Summary
|
Comment on lines
+203
to
+213
| let selection = match query.body.as_ref() { | ||
| SetExpr::Select(selection) => selection, | ||
| SetExpr::Query(_) => unsupported_sql_err!("Subqueries are not supported"), | ||
| SetExpr::SetOperation { .. } => { | ||
| unsupported_sql_err!("Set operations are not supported") | ||
| } | ||
| SetExpr::Values(..) => unsupported_sql_err!("VALUES are not supported"), | ||
| SetExpr::Insert(..) => unsupported_sql_err!("INSERT is not supported"), | ||
| SetExpr::Update(..) => unsupported_sql_err!("UPDATE is not supported"), | ||
| SetExpr::Table(..) => unsupported_sql_err!("TABLE is not supported"), | ||
| }; |
There was a problem hiding this comment.
a small drive-by to provide better error messages here.
Comment on lines
+593
to
+615
| sqlparser::ast::TableFactor::TableFunction { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: TableFunction") | ||
| } | ||
| sqlparser::ast::TableFactor::Function { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: Function") | ||
| } | ||
| sqlparser::ast::TableFactor::UNNEST { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: UNNEST") | ||
| } | ||
| sqlparser::ast::TableFactor::JsonTable { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: JsonTable") | ||
| } | ||
| sqlparser::ast::TableFactor::NestedJoin { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: NestedJoin") | ||
| } | ||
| sqlparser::ast::TableFactor::Pivot { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: Pivot") | ||
| } | ||
| sqlparser::ast::TableFactor::Unpivot { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: Unpivot") | ||
| } | ||
| sqlparser::ast::TableFactor::MatchRecognize { .. } => { | ||
| unsupported_sql_err!("Unsupported table factor: MatchRecognize") |
There was a problem hiding this comment.
another small driveby for better error messages
sagiahrac
pushed a commit
to sagiahrac/Daft
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.