[FEAT] dec128 math #3143
Merged
[FEAT] dec128 math #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samster25
commented
Oct 29, 2024
•
samster25
commented
- Removes Int128 Type
- Refactor Decimal128 to be backed by a DataArray rather than a LogicalArray
- Implements math operations for Decimal
- Implements comparison operations for Decimal
CodSpeed Performance ReportMerging #3143 will not alter performanceComparing Summary
|
| impl Add for &Decimal128Array { | ||
| type Output = DaftResult<Decimal128Array>; | ||
| fn add(self, rhs: Self) -> Self::Output { | ||
| assert_eq!(self.data_type(), rhs.data_type()); |
There was a problem hiding this comment.
should we instead return an error instead of panicking if the types dont match?
There was a problem hiding this comment.
This should hopefully never happen since the series code should correctly match cast the types before this gets called.
Comment on lines
+380
to
+381
| let l = unsafe { values.get_unchecked(a) }; | ||
| let r = unsafe { values.get_unchecked(b) }; |
There was a problem hiding this comment.
Can you add some SAFETY comments explaining why this won't go out of bounds.
Comment on lines
+397
to
+398
| let l = unsafe { values.get_unchecked(a) }; | ||
| let r = unsafe { values.get_unchecked(b) }; |
samster25
force-pushed
the
sammy/decimal128
branch
from
a7c5af7
to
618daa5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
==========================================
- Coverage 78.80% 77.48% -1.33%
==========================================
Files 621 621
Lines 74809 76670 +1861
==========================================
+ Hits 58954 59405 +451
- Misses 15855 17265 +1410
|
universalmind303
approved these changes
Oct 30, 2024
|
@samster25 It looks like df = (
daft.from_pydict({"floats": [328.00, 300.00, 299.00]})
.select(col("floats").cast(daft.DataType.decimal128(5, 2)))
.where(col('floats').between(300, 400))
.collect()
) |
so i think this is actually an issue with the decimal casting. Here's a tiny PR to fix the panic. |
This was referenced Oct 31, 2024
sagiahrac
pushed a commit
to sagiahrac/Daft
that referenced
this pull request
Nov 4, 2024
* Removes Int128 Type * Refactor Decimal128 to be backed by a DataArray rather than a LogicalArray * Implements math operations for Decimal * Implements comparison operations for Decimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.