-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Add rust cache to s3 build artifacts action #3144
Conversation
CodSpeed Performance ReportMerging #3144 will not alter performanceComparing Summary
|
@@ -35,6 +35,10 @@ jobs: | |||
with: | |||
submodules: true | |||
fetch-depth: 0 | |||
- uses: Swatinem/rust-cache@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may not do anything since the build happens in a docker container for the messense/maturin-action
step
We should check if the target
dir is volume mounted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we should prob use sccache instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try turning on the sccache
option for the messense/maturin-action
step seen here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh lol yeah I was literally looking at this as you posted and saw the notification come up on the maturin-action issue 😂 . Going to try sccache
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
=======================================
Coverage 78.77% 78.78%
=======================================
Files 619 619
Lines 74621 74623 +2
=======================================
+ Hits 58783 58790 +7
+ Misses 15838 15833 -5 |
Reverts #3144 The rust cache did not work as intended. We should try sccache instead.
No description provided.