Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add rust cache to s3 build artifacts action #3144

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 29, 2024

No description provided.

@github-actions github-actions bot added the chore label Oct 29, 2024
@jaychia jaychia enabled auto-merge (squash) October 29, 2024 00:54
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #3144 will not alter performance

Comparing jay/rust-cache-build-s3 (dc3d49a) with main (b0a5a40)

Summary

✅ 17 untouched benchmarks

@jaychia jaychia merged commit 54bc14b into main Oct 29, 2024
42 checks passed
@jaychia jaychia deleted the jay/rust-cache-build-s3 branch October 29, 2024 01:11
@@ -35,6 +35,10 @@ jobs:
with:
submodules: true
fetch-depth: 0
- uses: Swatinem/rust-cache@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may not do anything since the build happens in a docker container for the messense/maturin-action step

We should check if the target dir is volume mounted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should prob use sccache instead

PyO3/maturin-action#53

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try turning on the sccache option for the messense/maturin-action step seen here:

https://github.com/PyO3/maturin-action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol yeah I was literally looking at this as you posted and saw the notification come up on the maturin-action issue 😂 . Going to try sccache

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (b0a5a40) to head (dc3d49a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3144   +/-   ##
=======================================
  Coverage   78.77%   78.78%           
=======================================
  Files         619      619           
  Lines       74621    74623    +2     
=======================================
+ Hits        58783    58790    +7     
+ Misses      15838    15833    -5     

see 3 files with indirect coverage changes

jaychia added a commit that referenced this pull request Oct 29, 2024
jaychia added a commit that referenced this pull request Oct 29, 2024
Reverts #3144

The rust cache did not work as intended. We should try sccache instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants