[FEAT] Support SQL INTERVAL
#3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Liu <[email protected]> Add `chrono` crate Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
CodSpeed Performance ReportMerging #3146 will not alter performanceComparing Summary
|
Signed-off-by: Austin Liu <[email protected]>
There was a problem hiding this comment.
thanks @austin362667 this looks pretty good for the most part. One more small change, then I think we can merge it in!
Signed-off-by: Austin Liu <[email protected]> Remove `chrono` crate Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
feat/support_interval_sql
branch
from
b93b700
to
6432e48
Compare
sagiahrac
pushed a commit
to sagiahrac/Daft
that referenced
this pull request
Nov 4, 2024
## The Rationales Thanks to the [great work](Eventual-Inc#3018) from @universalmind303 , Daft now supports `INTERVAL` type exposed from `arrow2`. Beyond DataFrame supports, this PR aims to unlock SQL simple `INTERVAL` usage in SQL syntax, mainly copied from [planner.rs](https://github.com/sgl-project/sglang/pull/1790/files#diff-ea02b059cdabc0939616c35c6566dbcf980a5794306dedd241c2823afd9b2db2). Notes: This naive impl doesn't fully support complex interval scenarios, like leap year or relative duration addition and subtraction. We might need more carefully handled logic as the follow ups. --------- Signed-off-by: Austin Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rationales
Thanks to the great work from @universalmind303 , Daft now supports
INTERVALtype exposed fromarrow2.Beyond DataFrame supports, this PR aims to unlock SQL simple
INTERVALusage in SQL syntax, mainly copied from planner.rs.Notes: This naive impl doesn't fully support complex interval scenarios, like leap year or relative duration addition and subtraction. We might need more carefully handled logic as the follow ups.