-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Pre Shuffle Merge Strategy #3191
Draft
colin-ho
wants to merge
8
commits into
main
Choose a base branch
from
colin/preshufflemerge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3191 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3191 +/- ##
==========================================
+ Coverage 78.82% 78.96% +0.14%
==========================================
Files 621 638 +17
Lines 74922 78196 +3274
==========================================
+ Hits 59058 61751 +2693
- Misses 15864 16445 +581
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables an experimental pre-shuffle merge strategy for shuffles.
Our traditional shuffle strategy is a fully materializing map-reduce. Each of the
M
map partition tasks ends in a fanout, producingN
output partitions, and thenN
reduce partition tasks are ran to mergeM
outputs each.The pre-shuffle merge strategy works by merging
P
map partition tasks, before doing a fanout. TheN
reduce partition tasks will now only have to mergeM/P
outputs. The benefit here is that we can reduce the total number of intermediate objects by a factor ofP
, i.e. fromM * N
toM / P * N
.I tested this on a 1000 x 1000 shuffle of 100kb partitions. with
P = 8
There are 2 big TODOs here:
P
. We can make this dynamic by setting some memory size threshold, or statically configure it based on number of map tasks and some assumptions on node memory capacity. Even if it's just2
though, thats 50% reduction in intermediate objects, which can probably provide some decent improvements.