Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to .NET 8 #791

Closed
wants to merge 5 commits into from
Closed

Update to .NET 8 #791

wants to merge 5 commits into from

Conversation

Wartori54
Copy link
Contributor

@Wartori54 Wartori54 commented Jul 9, 2024 •
edited
Loading

Draft PR since we need to fix a few things still.

Necessary:

  • Update NLua submodule/get the pr merged and switch to a package
  • Verify that there is no floating point differences with the upgrade (basically run a long TAS)
  • Fix code mod building targeting a .NET 8 everest

Good to have but not strictly required:

  • Wait for an updated package for MonoMod.Patcher and MonoMod.RuntimeDetour.Hookgen to ditch the submodule
  • Relinker rewrite
  • Find a solution for old MacOS (or just not care about it) (update: game booted in a vm)
  • Make piton delete the old runtime (.NET 7) on upgrade Turns out it will be overwritten

I should note here that I upgraded the other nuget packages, since we might as well do it :P

@maddie480 maddie480 added the needs fixing This PR needs to be changed before being reviewed again label Jul 12, 2024
This was referenced Oct 6, 2024
Open
Open
@Wartori54
Copy link
Contributor Author

Closed in favour of #827 and #828.

@Wartori54 Wartori54 closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs fixing This PR needs to be changed before being reviewed again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wartori54 @maddie480