Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving favicon not showing #15

Merged
merged 1 commit into from
Aug 16, 2023
Merged

resolving favicon not showing #15

merged 1 commit into from
Aug 16, 2023

Conversation

Aliiiu
Copy link
Contributor

@Aliiiu Aliiiu commented Aug 16, 2023

Resolving Favicon Issue

In this PR

  • I worked on properly configuring the metadata files to show the favicon

Closes EveripediaNetwork/issues#1698
fixes: EveripediaNetwork/issues#1696

@stackblitz
Copy link

stackblitz bot commented Aug 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
braindao-ui ✅ Ready (Inspect) Visit Preview Aug 16, 2023 4:47pm

@Aliiiu Aliiiu merged commit 2c603e6 into main Aug 16, 2023
1 check passed
@@ -34,7 +34,8 @@
"**/*.ts",
"**/*.tsx",
".next/types/**/*.ts",
"/Applications/XAMPP/xamppfiles/htdocs/projects/Next/braindao-ui/.next/types/**/*.ts"
"/Applications/XAMPP/xamppfiles/htdocs/projects/Next/braindao-ui/.next/types/**/*.ts",
"/Users/aliusalaudeen/Documents/GitHub/braindao-ui/.next/types/**/*.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be having this pushed.

card: "summary_large_image",
url: "https://braindao.org",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove the url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim query input Inclusion of Favicon on the BrainDAO website
3 participants