Unit Test for Updated MarketCapResolver #594
Conversation
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }) | ||
|
|
||
| describe('rankPageIds', () => { | ||
| it('should update rank page ids', async () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| }) | ||
|
|
||
| describe('linkWikiToRankData', () => { | ||
| it('should link wiki to rank data with valid wikiId', async () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| }) | ||
|
|
||
| describe('rankPageIds', () => { | ||
| it('should update rank page ids', async () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| }) | ||
|
|
||
| describe('linkWikiToRankData', () => { | ||
| it('should link wiki to rank data with valid wikiId', async () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 389bc19 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| describe('linkWikiToRankData', () => { | ||
| it('should link wiki to rank data with valid wikiId', async () => { | ||
| const mockArgs: RankPageIdInputs = { | ||
| coingeckoId: 'iqcoin', | ||
| wikiId: 'wiki1', | ||
| kind: RankType.TOKEN, | ||
| } | ||
| ;(mockMarketCapService.updateMistachIds as jest.Mock).mockResolvedValue( | ||
| true, | ||
| ) | ||
|
|
||
| const result = await marketCapResolver.linkWikiToRankData(mockArgs) | ||
|
|
||
| expect(result).toBe(true) | ||
| expect(mockMarketCapService.updateMistachIds).toHaveBeenCalledWith( | ||
| mockArgs, | ||
| ) | ||
| }) |
There was a problem hiding this comment.
this test, we can also test that the update was successful by checking the updated cache for the changed value
Unit Test for Updated MarketCapResolver
Unit tests for the methods in marketCap.resolver.ts which includes the linkWikiToRankData, using mocks for dependencies to ensure the resolver's logic is tested independently and to ensure the data is updated and that on refresh we also see the updated value.
pnpm test marketCap.resolver.tspec.ts
closes EveripediaNetwork/issues#3243
And
closes EveripediaNetwork/issues#3291