chore(test/rule-matches): var -> const & let (dequelabs#4497)

For `test/rule-matches`

Smaller part of the full vision:
dequelabs#4444

test/rule-matches/aria-allowed-attr-matches.js

@@ -1,8 +1,8 @@
 describe('aria-allowed-attr-matches', function () {
   'use strict';
 
-  var queryFixture = axe.testUtils.queryFixture;
-  var rule;
+  const queryFixture = axe.testUtils.queryFixture;
+  let rule;
 
   beforeEach(function () {
     rule = axe.utils.getRule('aria-allowed-attr');
@@ -13,15 +13,15 @@ describe('aria-allowed-attr-matches', function () {
   });
 
   it('should return true on elements that have aria attributes', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<div role="button" id="target" aria-label="Thing 1" aria-mccheddarton="Unsupported thing 2"></div>'
     );
 
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('should return false on elements that have no aria attributes', function () {
-    var vNode = queryFixture('<div role="button" id="target"></div>');
+    const vNode = queryFixture('<div role="button" id="target"></div>');
 
     assert.isFalse(rule.matches(null, vNode));
   });

test/rule-matches/aria-allowed-role-matches.js

@@ -1,27 +1,29 @@
 describe('aria-allowed-role-matches', function () {
   'use strict';
 
-  var queryFixture = axe.testUtils.queryFixture;
-  var rule;
+  const queryFixture = axe.testUtils.queryFixture;
+  let rule;
 
   beforeEach(function () {
     rule = axe.utils.getRule('aria-allowed-role');
   });
 
   it('return false (no matches) for a <link> with a href to have any invalid role', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<link id="target" href="/example.com" role="invalid-role"></link>'
     );
     assert.isFalse(rule.matches(null, vNode));
   });
 
   it('return true for input with redundant role', function () {
-    var vNode = queryFixture('<input id="target" type="text" role="textbox"/>');
+    const vNode = queryFixture(
+      '<input id="target" type="text" role="textbox"/>'
+    );
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('return true for element with valid role', function () {
-    var vNode = queryFixture('<ol id="target" role="listbox"/>');
+    const vNode = queryFixture('<ol id="target" role="listbox"/>');
     assert.isTrue(rule.matches(null, vNode));
   });
 });

test/rule-matches/aria-has-attr-matches.js

@@ -1,9 +1,9 @@
 describe('aria-has-attr-matches', function () {
   'use strict';
 
-  var queryFixture = axe.testUtils.queryFixture;
-  var fixtureSetup = axe.testUtils.fixtureSetup;
-  var rule;
+  const queryFixture = axe.testUtils.queryFixture;
+  const fixtureSetup = axe.testUtils.fixtureSetup;
+  let rule;
 
   beforeEach(function () {
     rule = axe.utils.getRule('aria-valid-attr-value');
@@ -14,16 +14,16 @@ describe('aria-has-attr-matches', function () {
   });
 
   it('should return false if an element has no attributes', function () {
-    var vNode = fixtureSetup('<div></div>');
+    const vNode = fixtureSetup('<div></div>');
     assert.isFalse(rule.matches(null, vNode));
   });
 
   it('should return false if an element has no ARIA attributes', function () {
-    var vNode = queryFixture('<div id="target"></div>');
+    const vNode = queryFixture('<div id="target"></div>');
     assert.isFalse(rule.matches(null, vNode));
   });
   it('should return true if an element has ARIA attributes', function () {
-    var vNode = queryFixture('<div id="target" aria-bats="monkeys"></div>');
+    const vNode = queryFixture('<div id="target" aria-bats="monkeys"></div>');
     assert.isTrue(rule.matches(null, vNode));
   });
 });

test/rule-matches/aria-hidden-focus-matches.js

@@ -1,8 +1,8 @@
 describe('aria-hidden-focus-matches', function () {
   'use strict';
 
-  var rule;
-  var queryFixture = axe.testUtils.queryFixture;
+  let rule;
+  const queryFixture = axe.testUtils.queryFixture;
 
   beforeEach(function () {
     rule = axe.utils.getRule('aria-hidden-focus');
@@ -13,44 +13,44 @@ describe('aria-hidden-focus-matches', function () {
   });
 
   it('return true when there is no parent with aria-hidden', function () {
-    var vNode = queryFixture('<div id="target">' + '</div>');
-    var actual = rule.matches(vNode.actualNode);
+    const vNode = queryFixture('<div id="target">' + '</div>');
+    const actual = rule.matches(vNode.actualNode);
     assert.isTrue(actual);
   });
 
   it('return false when has a parent element with aria-hidden', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<div aria-hidden="true">' +
         '<div id="target" aria-hidden="true">' +
         '</div>' +
         '</div>'
     );
-    var actual = rule.matches(vNode.actualNode);
+    const actual = rule.matches(vNode.actualNode);
     assert.isFalse(actual);
   });
 
   it('return false when has any parent element with aria-hidden', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<div aria-hidden="true">' +
         '<div>' +
         '<div id="target" aria-hidden="true">' +
         '</div>' +
         '</div>' +
         '</div>'
     );
-    var actual = rule.matches(vNode.actualNode);
+    const actual = rule.matches(vNode.actualNode);
     assert.isFalse(actual);
   });
 
   it('return false when has any parent element with aria-hidden', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<div aria-hidden="true">' +
         '<div aria-hidden="true">' +
         '<button id="target">btn</button>' +
         '</div>' +
         '</div>'
     );
-    var actual = rule.matches(vNode.actualNode);
+    const actual = rule.matches(vNode.actualNode);
     assert.isFalse(actual);
   });
 });

test/rule-matches/aria-required-children-matches.js

@@ -1,9 +1,9 @@
 describe('aria-required-children-matches', function () {
   'use strict';
 
-  var fixture = document.getElementById('fixture');
-  var queryFixture = axe.testUtils.queryFixture;
-  var rule;
+  const fixture = document.getElementById('fixture');
+  const queryFixture = axe.testUtils.queryFixture;
+  let rule;
 
   beforeEach(function () {
     rule = axe.utils.getRule('aria-required-children');
@@ -14,12 +14,12 @@ describe('aria-required-children-matches', function () {
   });
 
   it('should return true for a role that requires children', function () {
-    var vNode = queryFixture('<div id="target" role="list"></div>');
+    const vNode = queryFixture('<div id="target" role="list"></div>');
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('should return false for a role that does not require children', function () {
-    var vNode = queryFixture('<div id="target" role="alert"></div>');
+    const vNode = queryFixture('<div id="target" role="alert"></div>');
     assert.isFalse(rule.matches(null, vNode));
   });
 });

test/rule-matches/aria-required-parent-matches.js

@@ -1,9 +1,9 @@
 describe('aria-required-parent-matches', function () {
   'use strict';
 
-  var fixture = document.getElementById('fixture');
-  var queryFixture = axe.testUtils.queryFixture;
-  var rule;
+  const fixture = document.getElementById('fixture');
+  const queryFixture = axe.testUtils.queryFixture;
+  let rule;
 
   beforeEach(function () {
     rule = axe.utils.getRule('aria-required-parent');
@@ -14,12 +14,12 @@ describe('aria-required-parent-matches', function () {
   });
 
   it('should return true for a role that requires parent', function () {
-    var vNode = queryFixture('<div id="target" role="listitem"></div>');
+    const vNode = queryFixture('<div id="target" role="listitem"></div>');
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('should return false for a role that does not require parent', function () {
-    var vNode = queryFixture('<div id="target" role="alert"></div>');
+    const vNode = queryFixture('<div id="target" role="alert"></div>');
     assert.isFalse(rule.matches(null, vNode));
   });
 });

test/rule-matches/autocomplete-matches.js

@@ -1,8 +1,8 @@
 describe('autocomplete-matches', function () {
   'use strict';
-  var fixture = document.getElementById('fixture');
-  var queryFixture = axe.testUtils.queryFixture;
-  var rule = axe.utils.getRule('autocomplete-valid');
+  const fixture = document.getElementById('fixture');
+  const queryFixture = axe.testUtils.queryFixture;
+  const rule = axe.utils.getRule('autocomplete-valid');
 
   afterEach(function () {
     fixture.innerHTML = '';
@@ -13,54 +13,54 @@ describe('autocomplete-matches', function () {
   });
 
   it('returns true for input elements', function () {
-    var vNode = queryFixture('<input id="target" autocomplete="foo">');
+    const vNode = queryFixture('<input id="target" autocomplete="foo">');
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('returns true for select elements', function () {
-    var vNode = queryFixture('<select id="target" autocomplete="foo">');
+    const vNode = queryFixture('<select id="target" autocomplete="foo">');
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('returns true for textarea elements', function () {
-    var vNode = queryFixture('<textarea id="target" autocomplete="foo">');
+    const vNode = queryFixture('<textarea id="target" autocomplete="foo">');
     assert.isTrue(rule.matches(null, vNode));
   });
 
   it('returns false for buttons elements', function () {
-    var vNode = queryFixture('<button id="target" autocomplete="foo">');
+    const vNode = queryFixture('<button id="target" autocomplete="foo">');
     assert.isFalse(rule.matches(null, vNode));
   });
 
   it('should return false for non-form field elements', function () {
-    var vNode = queryFixture('<div id="target" autocomplete="foo">');
+    const vNode = queryFixture('<div id="target" autocomplete="foo">');
     assert.isFalse(rule.matches(null, vNode));
   });
 
   it('returns false for input buttons', function () {
     ['reset', 'submit', 'button'].forEach(function (type) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<input id="target" type="' + type + '" autocomplete="foo">'
       );
       assert.isFalse(rule.matches(null, vNode));
     });
   });
 
   it('returns false for elements with an empty autocomplete', function () {
-    var vNode = queryFixture('<input id="target" autocomplete="  ">');
+    const vNode = queryFixture('<input id="target" autocomplete="  ">');
     assert.isFalse(rule.matches(null, vNode));
   });
 
   it('returns false for intput[type=hidden]', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<input id="target" type="hidden" autocomplete="foo">'
     );
     assert.isFalse(rule.matches(null, vNode));
   });
 
   it('returns false for disabled fields', function () {
     ['input', 'select', 'textarea'].forEach(function (tagName) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<' + tagName + ' id="target" disabled autocomplete="foo">'
       );
       assert.isFalse(rule.matches(null, vNode));
@@ -69,7 +69,7 @@ describe('autocomplete-matches', function () {
 
   it('returns false for aria-disabled=true fields', function () {
     ['input', 'select', 'textarea'].forEach(function (tagName) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<' + tagName + ' id="target" aria-disabled="true" autocomplete="foo">'
       );
       assert.isFalse(rule.matches(null, vNode));
@@ -78,17 +78,17 @@ describe('autocomplete-matches', function () {
 
   it('returns true for aria-disabled=false fields', function () {
     ['input', 'select', 'textarea'].forEach(function (tagName) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<' + tagName + ' id="target" aria-disabled="false" autocomplete="foo">'
       );
       assert.isTrue(rule.matches(null, vNode));
     });
   });
 
   it('returns false for non-widget roles with tabindex=-1', function () {
-    var nonWidgetRoles = ['application', 'fakerole', 'main'];
+    const nonWidgetRoles = ['application', 'fakerole', 'main'];
     nonWidgetRoles.forEach(function (role) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<input id="target" role="' +
           role +
           '" tabindex="-1" autocomplete="foo">'
@@ -101,9 +101,9 @@ describe('autocomplete-matches', function () {
   });
 
   it('returns true for form fields with a widget role with tabindex=-1', function () {
-    var nonWidgetRoles = ['button', 'menuitem', 'slider'];
+    const nonWidgetRoles = ['button', 'menuitem', 'slider'];
     nonWidgetRoles.forEach(function (role) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<input id="target" role="' +
           role +
           '" tabindex="-1" autocomplete="foo">'
@@ -114,15 +114,15 @@ describe('autocomplete-matches', function () {
 
   it('returns true for form fields with tabindex=-1', function () {
     ['input', 'select', 'textarea'].forEach(function (tagName) {
-      var vNode = queryFixture(
+      const vNode = queryFixture(
         '<' + tagName + ' id="target" tabindex="-1" autocomplete="foo">'
       );
       assert.isTrue(rule.matches(null, vNode));
     });
   });
 
   it('returns false for off screen and hidden form fields with tabindex=-1', function () {
-    var vNode = queryFixture(
+    const vNode = queryFixture(
       '<div aria-hidden="true">' +
         '<input id="target" tabindex="-1" style="position:absolute; top:-9999em" autocomplete="foo">' +
         '</div>'