Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

273 name encapsulation #286

Merged
merged 28 commits into from
Aug 18, 2024
Merged

273 name encapsulation #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ba756b1
Refactor live rankings
araszka Aug 7, 2024
027375b
Undo dependencies on live ranking
araszka Aug 7, 2024
8caf938
Use custom nicknames in live ranking widget
araszka Aug 9, 2024
0d6174e
Make live ranking detect points based game modes
araszka Aug 9, 2024
a4d31a7
Add no finishes info to live ranking widget
araszka Aug 9, 2024
c2e652f
Add LiveRankingModule controller tests
araszka Aug 9, 2024
5d00798
Add LiveRankingService doc comments
araszka Aug 9, 2024
e163431
Add live ranking service tests
araszka Aug 9, 2024
9deba0f
Add missing async method name suffix
araszka Aug 9, 2024
d6ffc45
Make utility classes non-async and add more tests for LiveRankingService
araszka Aug 10, 2024
8f166f9
Move live ranking styles to own component and create component for no…
araszka Aug 10, 2024
a2005ba
Add WidgetPosition enum
araszka Aug 10, 2024
048cc3e
Merge remote-tracking branch 'origin/master' into 219-redo-live-ranki…
araszka Aug 10, 2024
81528ec
Merge remote-tracking branch 'origin/master' into 284-improve-team-in…
araszka Aug 14, 2024
f7b9a34
Update points earlier in team info widget
araszka Aug 14, 2024
6f27369
Update team info module tests
araszka Aug 14, 2024
21fb769
Add TeamSettingsModule.SettingsUpdated event
araszka Aug 14, 2024
11c183f
Re-send team info widget if team settings have been updated
araszka Aug 14, 2024
073335e
Wording
araszka Aug 14, 2024
db018f9
Wording
araszka Aug 14, 2024
e65d865
Resolve code issues
araszka Aug 14, 2024
41ef09a
Update src/Modules/TeamInfoModule/Controllers/TeamInfoEventController.cs
araszka Aug 15, 2024
44e1a25
Raise team settings updated event async and delayed
araszka Aug 16, 2024
0da594a
Merge remote-tracking branch 'origin/284-improve-team-info-behaviour'…
araszka Aug 16, 2024
a9e6b43
Fix test
araszka Aug 16, 2024
9ed8eaf
Await delay instead of using ContinueWith
araszka Aug 16, 2024
9c28ccb
Merge remote-tracking branch 'origin/master' into 284-improve-team-in…
araszka Aug 18, 2024
48be9ca
Encapsulate potential styled strings in localizations and remove unus…
araszka Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Modules/MapsModule/Localization.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
<value>Map with ID {0} could not be found.</value>
</data>
<data name="MapAddedSuccessfully" xml:space="preserve">
<value>Added {0} by $&lt;{1}$&gt; to the server.</value>
<value>Added $&lt;{0}$&gt; by $&lt;{1}$&gt; to the server.</value>
</data>
<data name="MapRemovedSuccessfully" xml:space="preserve">
<value>Removed {0} by $&lt;{1}$&gt; from the server.</value>
<value>Removed $&lt;{0}$&gt; by $&lt;{1}$&gt; from the server.</value>
</data>
<data name="Audit.MapAdded" xml:space="preserve">
<value>Map was added.</value>
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/MatchManagerModule/Localization.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<value>{0} Available modes: $fff{1}</value>
</data>
<data name="LoadedMatchSettings" xml:space="preserve">
<value>{0} loaded match settings: {1}</value>
<value>$&lt;{0}$&gt; loaded match settings: {1}</value>
</data>
<data name="CannotFindMatchSettings" xml:space="preserve">
<value>Cannot find MatchSettings named '{0}'.</value>
Expand Down
3 changes: 0 additions & 3 deletions src/Modules/MatchReadyModule/Localization.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,4 @@
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="TestValue" xml:space="preserve">
<value>Hello {0}</value>
</data>
</root>
3 changes: 0 additions & 3 deletions src/Modules/MatchTrackerModule/Localization.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,4 @@
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="TestValue" xml:space="preserve">
<value>Hello {0}</value>
</data>
</root>
3 changes: 0 additions & 3 deletions src/Modules/MotdModule/Localization.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,4 @@
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="TestValue" xml:space="preserve">
<value>Hello {0}</value>
</data>
</root>
Loading