WRM: Handle Flurl http exceptions #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaeri
force-pushed
the
bugfix-WRM-crash
branch
from
e08414f
to
fd197cf
Compare
snixtho
approved these changes
Oct 4, 2024
|
That ci check wasn't there last time I checked 😞 Can't say I see anything actionable. Please let me know if there is anything you would like me to fix/change |
Qodana? You can ignore this as its just something we're testing out atm. |
Instead of throwing, we log an error message, and let it continue. This will let it use the local author record, and not crash. Update comment to inform about the possiblity of it returning without completing in the event of API errors. Fixed whitespace and formatting
flaeri
force-pushed
the
bugfix-WRM-crash
branch
from
972f9c0
to
f5d1bb7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of throwing, we log an error message, and let it continue. This will let it use the local author record, and not crash.
Update comment to inform about the possibility of it returning without completing in the event of API errors.
Fixed whitespace and formatting
Fixes #294
Tested locally on my machine with a custom made map that was not uploaded. It didnt crash/throw, and the AT was loaded. Tested a known good online map, and it correctly loaded the WR.
Bad map, log output: