Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InteractingScp330EventArgs::Candy #124

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix InteractingScp330EventArgs::Candy #124

wants to merge 1 commit into from

Conversation

VALERA771
Copy link

@VALERA771 VALERA771 commented Oct 4, 2024 •
edited
Loading

Description

Describe the changes
Fixing InteractingScp330EventArgs::Candy

What is the current behavior? (You can also link to an open issue here)
Candy is incorrect
#118

What is the new behavior? (if this is a feature change)
Candy is correct

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771 VALERA771 changed the title fix Fix InteractingScp330EventArgs::Candy Oct 4, 2024
iamalexrouse
iamalexrouse approved these changes Oct 5, 2024
View reviewed changes
Copy link

@iamalexrouse iamalexrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro styling fix. Otherwise, looks good.

EXILED/Exiled.Events/EventArgs/Scp330/InteractingScp330EventArgs.cs Show resolved Hide resolved
@louis1706 louis1706 linked an issue Oct 20, 2024 that may be closed by this pull request
[BUG] InteractingScp330 return the wrong CandyKindID #118
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis1706 louis1706 louis1706 approved these changes

@iamalexrouse iamalexrouse iamalexrouse approved these changes

Assignees

@VALERA771 VALERA771

Labels
API Events Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] InteractingScp330 return the wrong CandyKindID
3 participants
@VALERA771 @louis1706 @iamalexrouse