Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made it work because devs have no braincells :) <3 #132

Closed
wants to merge 2 commits into from

Conversation

stefanocep
Copy link

Description

Describe the changes
Fixed ambiguous reference in API/Features/Player
Made Exiled Custom items only unpatch its own patches
Fixed invalid enum to bool comparrison in CustomRoles/API/Features/KeypressActivator
Removed unnecessary harmony reference in CustomRoles

What is the current behavior? (You can also link to an open issue here)
It doesn't compile.

What is the new behavior? (if this is a feature change)
It now compiles.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:
kekw

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • [X ] I have checked the project can be compiled
  • [ X] I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix CI
  2. Contains some useless changes. Like in API.Features.Player

Idk why you think that it's broken cuz most of things that you're editing didn't change for a long time and are working on stable releases

@stefanocep
Copy link
Author

after some testing i realized only my repo of exiled was broken idk why but it dint wana compile in rider was giving me some issues after further testing i realized that it worked fine for others soo its useless yeah

@louis1706
Copy link

Not an issue

@louis1706 louis1706 closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants