-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXILED::Loader]
Allow port-binded plugin loading
#89
base: dev
Are you sure you want to change the base?
Conversation
Suggestion ExMod-Team#1 Co-authored-by: Alex Rouse <[email protected]>
Co-authored-by: Alex Rouse <[email protected]>
private methods should be defined after public ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems ok, just make some adjustments I've mentioned and you should be all good.
Co-authored-by: Alex Rouse <[email protected]>
Co-authored-by: Alex Rouse <[email protected]>
Co-authored-by: Alex Rouse <[email protected]>
let's hope to not upset the auto checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Tbh I don't see point for this pr. We have |
We don't have to remove the |
Just use pterodactyl and host servers in different containers 😛 |
This is actually the better approach when working with multiple ports, especially with a game such as SCP: SL Dedicated Server. If you knew what you were doing, you could symlink to a networked location where the plugins are stored, for each port, but in pretty much all use-cases, that's never really been used, or even should be used, for obvious reasons. |
Lots of small SCP:SL servers uses the same machine to host multiple servers. |
I love this idea and ill try to make it go forward, but needs more discussion between how we want to structure it. |
For my pov it's seems ok if you can still show screen shot difference between before and now |
Description
Describe the changes
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other