Find workspace root #247
Find workspace root #247
Conversation
…ory for one of the project root files. The default list of project root files was copied from codeium.vim.
There was a problem hiding this comment.
Thanks for this PR, definitely the existing relative path wasn't computed correctly. The workspace_uri argument is expected to be file:///path/to/workspace (convention changed from relative path to the other path components basically) just like theabsolute_uri argument is expected to be file:///path/to/workspace/foo/bar.txt.
lua/codeium/util.lua
Outdated
| end | ||
|
|
||
| -- From the CWD, walk up the tree looking for a directory that contains one of the project root files | ||
| local candidates = config.options.project_root_paths |
There was a problem hiding this comment.
Maybe the source of candidates should be vim.lsp.buf.list_workspace_folders()?
There was a problem hiding this comment.
That seems like a good idea. Personally I'm actually still on coc.nvim so I'll probably keep the project_root_paths option as a fallback when list_workspace_folders returns nothing.
|
Ok I think this is looking good now. I implemented a 4-step process:
Confirmed that the chat context is working too. The filename appears in the "current" thing above the textbox and when I ask it "what is this file" it references the correct one :) |
dimfeld
changed the title
| -- From the CWD, walk up the tree looking for a directory that contains one of the project root files | ||
| local candidates = config.options.workspace_root.paths | ||
| local result = vim.fs.find(candidates, { | ||
| path = cwd, |
There was a problem hiding this comment.
@dimfeld where is this cwd variable coming from? I notice that this pr fixed things for mac, but on windows it fails. Seems the failure is because this cwd variable is nil. How does it get populated on mac?
There was a problem hiding this comment.
Ah sorry, that was missed when I was moving around some code. M.get_project_root should pass its wd variable to _get_project_root for the value of cwd.
There was a problem hiding this comment.
Submitted #248 as a fix
This provides a few methods of finding the workspace root (see comment below) and updates the calls that use
workspace_urito use it.Closes #244
Closes #238
Supersedes #243