Various changes I have needed

Exiled.API/Enums/Side.cs

@@ -26,7 +26,7 @@ public enum Side
         /// <summary>
         /// SCP team. Same as <see cref="Team.SCPs"/>.
         /// Contains all SCP-related roles: <see cref="RoleTypeId.Scp049"/>, <see cref="RoleTypeId.Scp0492"/>, <see cref="RoleTypeId.Scp079"/>, <see cref="RoleTypeId.Scp096"/>,
-        /// <see cref="RoleTypeId.Scp106"/>, <see cref="RoleTypeId.Scp173"/>, and <see cref="RoleTypeId.Scp939"/>.
+        /// <see cref="RoleTypeId.Scp106"/>, <see cref="RoleTypeId.Scp173"/>, <see cref="RoleTypeId.Scp939"/>, and <see cref="RoleTypeId.Scp3114"/>.
         /// </summary>
         Scp,
 

Exiled.API/Extensions/MirrorExtensions.cs

@@ -210,7 +210,7 @@ public static void SetName(this Player target, Player player, string name)
         /// <param name="room">Room to modify.</param>
         /// <param name="target">Only this player can see room color.</param>
         /// <param name="multiplier">Light intensity multiplier to set.</param>
-        [Obsolete("This features has been remove by NW", true)]
+        [Obsolete("This features has been removed by NW", true)]
         public static void SetRoomLightIntensityForTargetOnly(this Room room, Player target, float multiplier)
         {
         }

Exiled.API/Features/DamageHandlers/ScpDamageHandler.cs

@@ -10,7 +10,7 @@ namespace Exiled.API.Features.DamageHandlers
     using Enums;
 
     using Extensions;
-
+    using PlayerRoles.PlayableScps.Scp3114;
     using PlayerStatsSystem;
 
     using BaseHandler = PlayerStatsSystem.DamageHandlerBase;

Exiled.API/Features/Hazards/TantrumHazard.cs

@@ -1,4 +1,4 @@
-// -----------------------------------------------------------------------
+// -----------------------------------------------------------------------
 // <copyright file="TantrumHazard.cs" company="Exiled Team">
 // Copyright (c) Exiled Team. All rights reserved.
 // Licensed under the CC BY-SA 3.0 license.

Exiled.API/Features/Npc.cs

@@ -11,6 +11,7 @@ namespace Exiled.API.Features
     using System;
     using System.Collections.Generic;
     using System.Linq;
+    using System.Reflection;
 
     using CommandSystem;
 
@@ -127,7 +128,7 @@ public Npc(GameObject gameObject)
         /// </summary>
         /// <param name="name">The name of the NPC.</param>
         /// <param name="role">The RoleTypeId of the NPC.</param>
-        /// <param name="id">The player ID of the NPC.</param>
+        /// <param name="id">The Network ID of the NPC. If 0, one is made.</param>
         /// <param name="userId">The userID of the NPC.</param>
         /// <param name="position">The position to spawn the NPC.</param>
         /// <returns>The <see cref="Npc"/> spawned.</returns>
@@ -148,17 +149,15 @@ public static Npc Spawn(string name, RoleTypeId role, int id = 0, string userId
                 Log.Debug($"Ignore: {e}");
             }
 
-            if (RecyclablePlayerId.FreeIds.Contains(id))
+            if (!RecyclablePlayerId.FreeIds.Contains(id) && RecyclablePlayerId._autoIncrement >= id)
             {
-                RecyclablePlayerId.FreeIds.RemoveFromQueue(id);
-            }
-            else if (RecyclablePlayerId._autoIncrement >= id)
-            {
-                RecyclablePlayerId._autoIncrement = id = RecyclablePlayerId._autoIncrement + 1;
+                Log.Warn($"{Assembly.GetCallingAssembly().GetName().Name} tried to spawn an NPC with a duplicate PlayerID. Using auto-incremented ID instead to avoid issues..");
+                id = new RecyclablePlayerId(false).Value;
             }
 
             FakeConnection fakeConnection = new(id);
             NetworkServer.AddPlayerForConnection(fakeConnection, newObject);
+
             try
             {
                 npc.ReferenceHub.authManager.UserId = string.IsNullOrEmpty(userId) ? $"Dummy@localhost" : userId;
@@ -172,7 +171,7 @@ public static Npc Spawn(string name, RoleTypeId role, int id = 0, string userId
             Dictionary.Add(newObject, npc);
 
             Timing.CallDelayed(
-                0.3f,
+                0.5f,
                 () =>
                 {
                     npc.Role.Set(role, SpawnReason.RoundStart, position is null ? RoleSpawnFlags.All : RoleSpawnFlags.AssignInventory);
@@ -189,12 +188,10 @@ public static Npc Spawn(string name, RoleTypeId role, int id = 0, string userId
         public void Destroy()
         {
             NetworkConnectionToClient conn = ReferenceHub.connectionToClient;
-            if (ReferenceHub._playerId.Value <= RecyclablePlayerId._autoIncrement)
-                ReferenceHub._playerId.Destroy();
             ReferenceHub.OnDestroy();
             CustomNetworkManager.TypedSingleton.OnServerDisconnect(conn);
             Dictionary.Remove(GameObject);
             Object.Destroy(GameObject);
         }
     }
-}
+}

Exiled.API/Features/Pickups/Pickup.cs

@@ -291,7 +291,7 @@ public Quaternion Rotation
         /// <summary>
         /// Gets a value indicating whether this pickup is spawned.
         /// </summary>
-        public bool IsSpawned => NetworkServer.spawned.ContainsValue(Base.netIdentity);
+        public bool IsSpawned { get; internal set; }
 
         /// <summary>
         /// Gets an existing <see cref="Pickup"/> or creates a new instance of one.
@@ -541,6 +541,7 @@ public void Spawn()
             if (!IsSpawned)
             {
                 NetworkServer.Spawn(GameObject);
+                IsSpawned = true;
             }
         }
 
@@ -571,6 +572,7 @@ public void UnSpawn()
         {
             if (IsSpawned)
             {
+                IsSpawned = false;
                 NetworkServer.UnSpawn(GameObject);
             }
         }

Exiled.API/Features/Player.cs

@@ -619,7 +619,7 @@ public ScpSpawnPreferences.SpawnPreferences ScpPreferences
         /// <summary>
         /// Gets a value indicating whether or not the player is jumping.
         /// </summary>
-        public bool IsJumping { get; internal set; }
+        public bool IsJumping => Role is FpcRole fpc && fpc.FirstPersonController.FpcModule.Motor.IsJumping;
 
         /// <summary>
         /// Gets the player's IP address.
@@ -3117,7 +3117,7 @@ public void ChangeEffectIntensity(EffectType type, byte intensity, float duratio
             if (TryGetEffect(type, out StatusEffectBase statusEffect))
             {
                 statusEffect.Intensity = intensity;
-                statusEffect.ServerChangeDuration(duration, true);
+                statusEffect.ServerChangeDuration(duration, false);
             }
         }
 

Exiled.CustomItems/API/Features/CustomGrenade.cs

@@ -49,7 +49,7 @@ public override ItemType Type
         }
 
         /// <summary>
-        /// Gets or sets a value indicating whether gets or sets a value that determines if the grenade should explode immediately when contacting any surface.
+        /// Gets or sets a value indicating whether or not the grenade should explode immediately when contacting any surface.
         /// </summary>
         public abstract bool ExplodeOnCollision { get; set; }
 

Exiled.CustomRoles/API/Extensions.cs

@@ -104,5 +104,32 @@ public static void Unregister(this IEnumerable<CustomRole> customRoles)
         /// <param name="player">The <see cref="Player"/> to check.</param>
         /// <returns>The <see cref="ActiveAbility"/> the <see cref="Player"/> has selected, or <see langword="null"/>.</returns>
         public static ActiveAbility? GetSelectedAbility(this Player player) => !ActiveAbility.AllActiveAbilities.TryGetValue(player, out HashSet<ActiveAbility> abilities) ? null : abilities.FirstOrDefault(a => a.Check(player, CheckType.Selected));
+
+        /// <summary>
+        /// Gets all <see cref="PassiveAbility"/>'s the <see cref="Player"/> currently has.
+        /// </summary>
+        /// <param name="player">The <see cref="Player"/> to get abilities for.</param>
+        /// <returns>An <see cref="IEnumerable{T}"/> of <see cref="PassiveAbility"/>s the player has.</returns>
+        public static IEnumerable<PassiveAbility> GetPassiveAbilities(this Player player)
+        {
+            foreach (CustomAbility ability in CustomAbility.Registered)
+            {
+                if (ability is PassiveAbility passive && ability.Check(player))
+                    yield return passive;
+            }
+        }
+
+        /// <summary>
+        /// Checks to see if a <see cref="Player"/> has a specific <see cref="CustomAbility"/>.
+        /// </summary>
+        /// <param name="player">The <see cref="Player"/> to check for the ability.</param>
+        /// <typeparam name="T">The <see cref="Type"/> of the ability to look for.</typeparam>
+        /// <returns><see langword="true"/> if the player has the ability, otherwise <see langword="false"/>.</returns>
+        public static bool HasAbility<T>(Player player)
+            where T : CustomAbility
+        {
+            CustomAbility? ability = CustomAbility.Get(typeof(T));
+            return ability is ActiveAbility active ? active.Check(player, CheckType.Available) : ability?.Check(player) ?? false;
+        }
     }
 }

Exiled.CustomRoles/API/Features/ActiveAbility.cs

@@ -61,6 +61,11 @@ public abstract class ActiveAbility : CustomAbility
         [YamlIgnore]
         public HashSet<Player> SelectedPlayers { get; } = new();
 
+        /// <summary>
+        /// Gets or sets the ability activation message.
+        /// </summary>
+        public virtual string? ActivationMessage { get; set; }
+
         /// <summary>
         /// Uses the ability.
         /// </summary>
@@ -73,6 +78,19 @@ public void UseAbility(Player player)
             Timing.CallDelayed(Duration, () => EndAbility(player));
         }
 
+        /// <summary>
+        /// Uses the ability.
+        /// </summary>
+        /// <param name="player">The <see cref="Player"/> using the ability.</param>
+        /// <param name="args">An array of additional arguments.</param>
+        public void UseAbility(Player player, params object[] args)
+        {
+            ActivePlayers.Add(player);
+            LastUsed[player] = DateTime.Now;
+            AbilityUsed(player, args);
+            Timing.CallDelayed(Duration, () => EndAbility(player));
+        }
+
         /// <summary>
         /// Ends the ability.
         /// </summary>
@@ -183,14 +201,17 @@ public virtual bool CanUseAbility(Player player, out string response, bool selec
             }
 
             response =
-                $"You must wait another {Math.Round((usableTime - DateTime.Now).TotalSeconds, 2)} seconds to use {Name}";
+                $"You must wait another {Math.Round((usableTime - DateTime.Now).TotalSeconds, MidpointRounding.AwayFromZero)} seconds to use {Name}";
 
             return false;
         }
 
         /// <inheritdoc />
         protected override void AbilityAdded(Player player)
         {
+            if (LastUsed.ContainsKey(player))
+                LastUsed.Remove(player);
+
             if (!AllActiveAbilities.ContainsKey(player))
                 AllActiveAbilities.Add(player, new());
 
@@ -219,6 +240,15 @@ protected virtual void AbilityUsed(Player player)
         {
         }
 
+        /// <summary>
+        /// Called when the ability is used.
+        /// </summary>
+        /// <param name="player">The <see cref="Player"/> using the ability.</param>
+        /// <param name="args">The additional arguments.</param>
+        protected virtual void AbilityUsed(Player player, params object[] args)
+        {
+        }
+
         /// <summary>
         /// Called when the abilities duration has ended.
         /// </summary>

Exiled.CustomRoles/API/Features/CustomAbility.cs

@@ -64,7 +64,7 @@ public CustomAbility()
         /// </summary>
         /// <param name="name">The name of the ability to get.</param>
         /// <returns>The ability, or <see langword="null"/> if it doesn't exist.</returns>
-        public static CustomAbility? Get(string name) => Registered?.FirstOrDefault(r => r.Name == name);
+        public static CustomAbility? Get(string name) => Registered?.FirstOrDefault(r => r.Name.ToLower() == name);
 
         /// <summary>
         /// Gets a <see cref="CustomAbility"/> by type.