Allow ID_Dedicated/null for Npc.UserId Parameter. Additional functionality: - Npc.LookAt - Npc.ShootWeapon - Npc.SetAimDownSight - Player.UnloadWeapon - Player.ToggleWeaponFlashlight

[creepycats]

Use ID_Dedicated or null to ensure an NPC is VSR Compliant (Uses Unverified/DedicatedHost instances, which will not take up slots or show on the Player List)

Added Multiple Functions for NPC characters to Look at Points, and use a Held Firearm (Shooting, ADS, Flashlight, Reloading)

Had to remake this cause I fricked up branches 😅

[creepycats]

Cedric on his way to demolish my PR:

[NotIntense]

Using ID_Dedicated for me, as shown in the provided screenshots, doesn't prevent the NPC from showing in the player list/appearing in player count.

[VALERA771]

Using ID_Dedicated for me, as shown in the provided screenshots, doesn't prevent the NPC from showing in the player list/appearing in player count.

Just changing id doesn't change anything if you aren't using this PR

[creepycats]

Yeah, with the PR, it should set the InstanceMode to DedicatedServer just like my previous fix functions for plugins did, which did appear to work properly.

Also this was literally one of if not the final solutions we had made when looking a few months ago to solve the issue.

[creepycats]

Update: I DID miss something Lmfao, you cant set npc.ReferenceHub.authManager.UserId with the Dedicated Server like I did. You have to instead use npc.ReferenceHub.authManager.SyncedUserId. Ill commit the change real quick.

[NotIntense]

Using ID_Dedicated for me, as shown in the provided screenshots, doesn't prevent the NPC from showing in the player list/appearing in player count.

Just changing id doesn't change anything if you aren't using this PR

Dumbass, I was

[creepycats]

I've also added support for null alongside ID_Dedicated. This gives you the option of plain Unverified players and Dedicated Server players. Issue should be resolved.

[creepycats]

Did my best to get it working before I had to leave. Noticed I also overrode the shooting position when hitting players. Anyways, I simplified the if returns into one function, and use an IDestructible instead of NetworkIdentity.

[creepycats]

Gonna change more things and do comment stuff. Renaming functions to be more clear, etc

[creepycats]

Should be all done. Might need to fix a bug or two if it comes up, but this should work.

• Function Names are Clearer
• They return a bool depending on if the requests are received or if the player is not able to send the request.
• Added Documentation for the bool returns
• I THINK I shortened the two if->return statements into one for each one
  (if (RoleManager.CurrentRole is not IFpcRole fpc || ReferenceHub.inventory._curInstance is not Firearm firearm))
• NetworkIdentity replaced with IDestructible, using Game's own weapon logic

[creepycats]

Fixed Documentation with past commits, and also removed the ReloadWeapon function from NPCs since Player apparently has it already. I might move everything except for the ShootWeapon function in the Weapon stuff to Player as well.

[creepycats]

Quickly moved my weapon and LookAt functions to Player.cs from NPC.cs. This is NOT tested and I will be modifying them in ~3 hours to fit the current function for Reloading. Will look for review afterwards.

[creepycats]

Should be good to go.

• Consistency with ReloadWeapon for others
• Moved LookAt, ShootWeapon and SetAimDownSight back to NPC since they only seem to work properly there.
• Rewrote LookAt since it for some reason didn't work with players or at all using the shortcut method, so I use smth else
• Removed Lerp parameter for LookAt
• Converted InventorySystem Firearm to be based on Exiled's Firearm
• Fixed ReloadWeapon function previously present, where multiple Messages caused multiple reloads at once, instead of denying repeated requests after the first. (Discovered whilst testing UnloadWeapon)

All was tested privately. VSR-options for NPCs (null/ID_Dedicated) works perfectly, and all Player tied functions work on both the client and server. Any function that didnt was moved to NPC specifically for their control (AKA Looking around, Shooting, and ADSing)

[creepycats]

Made two small changes to Documentation, sorry it took so long i got eepy