[Exiled::Events] Adding AddingObserver and RemovingObserver events for Scp173
#2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain) the adding observer is triggered when a user just saw scp 173. for example, if ev.IsAllowed is set to false and the user is the only one who can saw scp173, the peanut can keep moving (it will be not added in the Observers list) an example when the ev.IsAllowed is set to false  he RemovingObserver is the same as the AddingObserver event but there is no a IsAllowed parameter (it's weird in this situation) and it's trigger when the player no longer saw scp173. special thanks to Bolton who help me to find stupid IL errors special thing to yamato: i have compile this xmas-2023 version in release buildedit: ho i forgot to tell: i have build all change and tested the events with a different plugin in my personnal server
|
i think it's good now |
NaoUnderscore
requested changes
Jan 14, 2024
fixing nao change requested (comment lines)
NaoUnderscore
approved these changes
Jan 25, 2024
NaoUnderscore
changed the title
[EXiled::Events] Adding AddingObserver and RemovingObserver events for Scp173
- change `Exiled.API.Features.Pools` using to `Exiled.API.Features.Core.Generic.Pools`
skyfr0676
changed the title
[EXiled::Events] Adding AddingObserver and RemovingObserver events for Scp173[Exiled::Events] Adding AddingObserver and RemovingObserver events for Scp173
|
Fix build errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the adding observer is triggered when a user just saw scp 173. for example, if ev.IsAllowed is set to false and the user is the only one who can saw scp173, the peanut can keep moving (it will be not added in the Observers list)
an example when the ev.IsAllowed is set to false
the RemoveObserver is the same as the AddingObserver event but there is no a IsAllowed parameter (it's weird in this situation) and it's trigger when the player no longer seen scp173.
special thanks to Bolton who help me to find stupid IL errors
special thing to yamato: i have compile this version in release build
edit: ho i forgot to tell: i have build all change and tested the events with a different plugin in my personnal server