CustomItemsUnhold & CustomItemsHolded #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Banalny-Banan
commented
Jul 9, 2024
| @@ -64,12 +64,12 @@ public abstract class CustomItem : CustomModule, IAdditiveBehaviour | |||
| /// <summary> | |||
| /// Gets all pickups belonging to a <see cref="CustomItem"/>. | |||
| /// </summary> | |||
| public static HashSet<Pickup> CustomItemsUnhold => PickupManager.Keys.ToHashSet(); | |||
| public static IEnumerable<Pickup> CustomPickups => PickupManager.Keys.ToHashSet(); | |||
There was a problem hiding this comment.
HashSets are usually prefered cause of their O(1) search, but here it is nowhere close to being O(1) as it is O(n) just to access cause of ToHashSet() call, so i think it is reasonable to make it IEnumerable
There was a problem hiding this comment.
I don't think that this is necessarily. Value will still be hash set so nothing will change (or you forgot to remove ToHashSet()?)
iamalexrouse
approved these changes
Jul 10, 2024
Misfiy
approved these changes
Jul 10, 2024
louis1706
requested changes
Jul 10, 2024
|
Requested review from nao to make sure that making this hash set was intended or not |
NaoUnderscore
requested changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current name is a bad one, calling .ToHashSet() every time property is accessed is heavily unoptimized, as it basicaly calls HashSet.Add for every item