Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canon EF 35-80mm f/4-5.6 II and III are named just like the original Canon EF 35-80mm f/4-5.6 #2247

Closed
PeterWem opened this issue Jun 10, 2022 · 3 comments
Closed

Canon EF 35-80mm f/4-5.6 II and III are named just like the original Canon EF 35-80mm f/4-5.6 #2247

PeterWem opened this issue Jun 10, 2022 · 3 comments
Labels
bug lens Issue related to lens detection

Comments

@PeterWem
Copy link

PeterWem commented Jun 10, 2022 •
edited
Loading

EF35-80

Canon has five EF 35-80 lenses and exiv2 reports the same name for three of them for the LensType tag.

To Reproduce

Sample raw files CC0 license https://drive.google.com/file/d/1fnxPGsF_daav3ej16DKlIgfh2gBJ4_Vh/view?usp=sharing
exiv2-pt
exiv2-pv

exiv2 version 0.27.5

Expected behavior

LensType 35 should be named Canon EF 35-80mm f/4-5.6 II
LensType 37 should be named Canon EF 35-80mm f/4-5.6 III

Desktop (please complete the following information):
  • Ubuntu 20.04
@PeterWem PeterWem added the bug label Jun 10, 2022
hassec added a commit that referenced this issue Jun 10, 2022
@hassec
fix naming of canon EF 35-80mm.closes #2247
16d72c9
@PeterWem
Copy link
Author

Thanks!

@hassec
Copy link
Member

hassec commented Jun 10, 2022

Thanks for the report! 👍

hassec added a commit that referenced this issue Jun 10, 2022
@hassec
add files from #2247 to regression test suite
333c436
@kmilos
Copy link
Collaborator

kmilos commented Jun 12, 2022 •
edited
Loading

Might be an idea to report this over at https://github.com/exiftool/exiftool as well: @boardhead

https://exiftool.org/TagNames/Canon.html

@kmilos kmilos added the lens Issue related to lens detection label Jun 13, 2022
kevinbackhouse added a commit that referenced this issue Jul 5, 2022
@kevinbackhouse
Merge pull request #2248 from Exiv2/hassec_fix_2247
5e4eab0 
fix naming of canon EF 35-80mm. closes #2247
mergify bot pushed a commit that referenced this issue Jul 5, 2022
@hassec @mergify
fix naming of canon EF 35-80mm.closes #2247
a33d97a 
(cherry picked from commit 16d72c9)

# Conflicts:
#	src/canonmn_int.cpp
mergify bot pushed a commit that referenced this issue Jul 5, 2022
@hassec @mergify
add files from #2247 to regression test suite
803db5b 
(cherry picked from commit 333c436)

# Conflicts:
#	test/data/20220610_MG_7237.exv.out
#	test/data/20220610_MG_7238.exv.out
#	test/data/20220610_MG_7239.exv.out
#	test/data/20220610_MG_7240.exv.out
#	test/data/20220610_MG_7241.exv.out
kevinbackhouse pushed a commit that referenced this issue Jul 27, 2022
@hassec @kevinbackhouse
fix naming of canon EF 35-80mm.closes #2247
69562c5
kevinbackhouse pushed a commit that referenced this issue Jul 27, 2022
@hassec @kevinbackhouse
add files from #2247 to regression test suite
2abbee8
kmilos added a commit that referenced this issue Aug 5, 2022
@kmilos
Merge pull request #2261 from Exiv2/mergify/bp/0.27-maintenance/pr-2248
aadb126 
fix naming of canon EF 35-80mm. closes #2247 (backport #2248)
@nehaljwani nehaljwani mentioned this issue Jan 16, 2023
Closed
antermin pushed a commit to antermin/exiv2 that referenced this issue Mar 16, 2023
@hassec @antermin
fix naming of canon EF 35-80mm.closes Exiv2#2247
0236a40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug lens Issue related to lens detection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kmilos @hassec @PeterWem