-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pull request about to integrate HEIF support (read only) using system based libheif #1233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 71.24% 71.91% +0.66%
==========================================
Files 148 152 +4
Lines 19457 17674 -1783
==========================================
- Hits 13862 12710 -1152
+ Misses 5595 4964 -631
Continue to review full report at Codecov.
|
Thank You for your hard work on this, @cgilles I won't be accepting this on the 0.27-maintenance branch at this time as it's in Code Freeze for v0.27.3 which is scheduled for release on 2020-06-30. I see you are requesting that information about this be added to README.md and I'll take care of this at the time of releasing 0.28. Can you open a feature request, assign it to me and milestone 0.28. This PR takes us into the hotly disputed subject of reading ISOBMFF files. I have set up a Team Exiv2 Meeting to discuss this. Topic: Exiv2 and ISOBMFF Support Join Zoom Meeting Meeting ID: 821 3673 0279 |
I'm unable to apply the patch to
There doesn't appear to be anything added to the test suite for this.
|
I'm not OK about this. This is a huge change. There's no test code. I've called a meeting on Sunday to discuss ISOBMFF. |
Sorry i post on wrong github file. Look my comment here 👍 |
Gilles: This is a mess. Please start again with a clean and simple PR wich includes updates to the test suite. |
A "mess". You are serious ???? [gilles@localhost exiv2]$ pwd
warning: 1 line adds whitespace errors. Changes not staged for commit:
Why not take time to read my work. Why you is faster to close all my file open on github ? what's the problem. Do you think that i'm a beginner ??? Seriouly i'm become really a waste of time, and my time is precious. If you want to see more contributors in the future, please take a care... Best regards Gilles Caulier |
Yes. I am serious. The patch couldn't be applied. There were about 50 new files and changes to about 30 existing files. And all of this to provide support for something about which the team is unhappy. And it's only readonly support. And there's not test coverage for the feature. Is this your idea of good work? |
@cgilles FYI, I successfully built exiv2 on Win from your branch cgilles:heif using libheif v1.7.0. |
To @tbeu : sure it compile fine under Linux, MacOs and Windows, as i use this kind of patch with digiKam everywhere now. ... You will seen that i'm "WORST OFFENDER" to Exiv2 project and especially for Mr Mills famous project management ! I close this parenthesis now, as i have no time to lost with Mr Mills... |
Folks, this isn't yet applied? |
@avibrazil Have a look here (for maint) or here (for master). |
Great to see it truly evolving in code. |
Hi
This PR is a new revision of my previous one, but it use now the libheif dependency from the host system.
the option to support HEIF in read only is disable by default in cmake. There is an option to enable it.
Patch README accordingly.
Important : with the last libheif release, new format are support, as HEIX and ... AVIF (using libaom in background). So this is full transparent from libexiv2, as all is done in background by libheif...
https://github.com/strukturag/libheif/releases
Best Regards
Gilles Caulier