Hide windows x86 random failures on CI #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
Coverage 66.92% 66.92%
=======================================
Files 151 151
Lines 20807 20807
=======================================
Hits 13925 13925
Misses 6882 6882 Continue to review full report at Codecov.
|
|
I initially thought the initial loop conversion PR was the cause. But reverting it doesn't seem to do anything. I don't have a MSVC setup either. |
piponazo
force-pushed
the
main-WindowsFailures
branch
from
5066ed5
to
cc9c644
Compare
piponazo
force-pushed
the
main-WindowsFailures
branch
from
67aa85d
to
5b7be5f
Compare
piponazo
force-pushed
the
main-WindowsFailures
branch
from
8d659e7
to
f71413c
Compare
On CI, pythonTests fail more or less consistently in the configuration Arch:x86, BuildType:Relase, Shared:ON. I tried to reproduce this locally, but I could not. Since Win-x86 is marginal for Exiv2, we disable it from CI until somebody raise concerns about it.
The idea is to generate a conan cache on main that could be reused in future PRs to main.
piponazo
requested review from
kmilos,
kevinbackhouse,
hassec and
neheb
and removed request for
kmilos
neheb
approved these changes
May 16, 2021
|
Note that I have updated the description with information about the changes done and the decision taken to not run the tests on Win x86. |
piponazo
changed the title
|
Works for me. x86 windows is a dying platform. X86 Linux and BSD are already not a thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After few days investigating the random windows x86 failures on CI (see link), I decided to give up since I could not reproduce them locally.
Anyways, the investigation bringts some improvements that I list here:
/Ox /Zo).cmake_find_packagegenerator we can simplify few things.tests/bugfixes/github/test_issue_1472.pywas failing on windows without a bash terminal.mainon push events.Finally I decided to not run the tests on windows x86 architectures to hide the failures. I think we do not lose too much since Windows x86 is marginal for Exiv2 and furthermore, I could not reproduce the failures locally.