clang-tidy: use auto #1660
Merged
clang-tidy: use auto #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
- Coverage 66.93% 66.92% -0.01%
==========================================
Files 151 151
Lines 20777 20775 -2
==========================================
- Hits 13907 13904 -3
- Misses 6870 6871 +1
Continue to review full report at Codecov.
|
Found with modernize-use-auto Signed-off-by: Rosen Penev <[email protected]>
piponazo
approved these changes
May 17, 2021
| const byte* nullComp = (const byte*) "\0\0"; | ||
| const byte* type = (const byte*) "iCCP"; | ||
| const uint32_t nameLength = static_cast<uint32_t>(profileName_.size()); | ||
| const auto nullComp = (const byte*)"\0\0"; |
There was a problem hiding this comment.
😱 ! Maybe we should move these constant literals to the anonymous space and just have them like this?
namespace {
const char* nullComp = "\0\0";
const char* type = "iCCP";
}
Note: I am not complaining about the change you did here, but just to the existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with modernize-use-auto
Signed-off-by: Rosen Penev [email protected]