Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: use C++ casting #1664

Merged
merged 1 commit into from
May 20, 2021
Merged

clang-tidy: use C++ casting #1664

merged 1 commit into from
May 20, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 19, 2021

Found with google-readability-casting

Signed-off-by: Rosen Penev [email protected]

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1664 (2dd9da0) into main (8dbc699) will increase coverage by 0.05%.
The diff coverage is 70.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1664      +/-   ##
==========================================
+ Coverage   66.89%   66.94%   +0.05%     
==========================================
  Files         151      151              
  Lines       20747    20746       -1     
==========================================
+ Hits        13879    13889      +10     
+ Misses       6868     6857      -11     
Impacted Files Coverage Δ
samples/exiv2json.cpp 75.60% <0.00%> (ø)
samples/getopt-test.cpp 0.00% <0.00%> (ø)
samples/mmap-test.cpp 0.00% <0.00%> (ø)
src/canonmn_int.cpp 73.23% <ø> (ø)
src/casiomn_int.cpp 7.14% <0.00%> (ø)
src/cr2image.cpp 9.72% <0.00%> (+0.51%) ⬆️
src/http.cpp 0.00% <0.00%> (ø)
src/image_int.cpp 41.17% <0.00%> (ø)
src/ini.cpp 6.73% <0.00%> (+0.06%) ⬆️
src/xmpsidecar.cpp 85.00% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbc699...2dd9da0. Read the comment docs.

@neheb neheb force-pushed the k branch 2 times, most recently from 03c3049 to 28f6658 Compare May 19, 2021 01:34
piponazo
piponazo previously approved these changes May 19, 2021
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Found with google-readability-casting

Signed-off-by: Rosen Penev <[email protected]>
@piponazo piponazo merged commit 743da1a into Exiv2:main May 20, 2021
@neheb neheb deleted the k branch May 20, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants