Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: use nullptr #1678

Merged
merged 1 commit into from
May 26, 2021
Merged

clang-tidy: use nullptr #1678

merged 1 commit into from
May 26, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 20, 2021

Found with modernize-use-nullptr

Signed-off-by: Rosen Penev [email protected]

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #1678 (19fad47) into main (86c71ae) will decrease coverage by 0.00%.
The diff coverage is 59.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
- Coverage   66.90%   66.90%   -0.01%     
==========================================
  Files         151      151              
  Lines       20725    20786      +61     
==========================================
+ Hits        13867    13907      +40     
- Misses       6858     6879      +21     
Impacted Files Coverage Δ
src/cr2image.cpp 9.72% <0.00%> (ø)
src/crwimage.cpp 71.01% <ø> (ø)
src/http.cpp 0.00% <0.00%> (ø)
src/ini.cpp 6.73% <0.00%> (ø)
src/olympusmn_int.cpp 20.46% <0.00%> (ø)
src/orfimage.cpp 44.59% <0.00%> (ø)
src/rw2image.cpp 43.90% <0.00%> (ø)
src/value.cpp 80.26% <0.00%> (ø)
unitTests/test_cr2header_int.cpp 100.00% <ø> (ø)
unitTests/test_slice.cpp 100.00% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c71ae...19fad47. Read the comment docs.

Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <[email protected]>
@neheb
Copy link
Collaborator Author

neheb commented May 25, 2021

Rebased.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@piponazo piponazo merged commit 2c57f21 into Exiv2:main May 26, 2021
@neheb neheb deleted the cast branch May 26, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants