Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove free() function from DataBuf #1687

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

hassec
Copy link
Member

@hassec hassec commented May 26, 2021

Small PR aiming to address #1542.

Instead of renaming free() I chose to remove it since we already have reset() in DataBuf which does the same when called with its default argument.

@hassec hassec added the refactoring Cleanup / Simplify code -> more readable / robust label May 26, 2021
@hassec hassec added this to the v1.00 milestone May 26, 2021
@hassec hassec requested a review from piponazo May 26, 2021 21:25
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #1687 (12d56ae) into main (2c57f21) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   66.90%   66.90%   -0.01%     
==========================================
  Files         151      151              
  Lines       20786    20781       -5     
==========================================
- Hits        13907    13903       -4     
+ Misses       6879     6878       -1     
Impacted Files Coverage Δ
include/exiv2/types.hpp 90.90% <ø> (+3.95%) ⬆️
src/types.cpp 95.98% <ø> (-0.05%) ⬇️
src/pngimage.cpp 78.90% <75.00%> (ø)
src/image.cpp 72.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c57f21...12d56ae. Read the comment docs.

@hassec hassec force-pushed the hassec_DataBuf_remove_free branch from 8500857 to 12d56ae Compare May 26, 2021 21:30
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@hassec hassec merged commit 758dd6b into main May 27, 2021
@mergify mergify bot deleted the hassec_DataBuf_remove_free branch May 27, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants