Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building for ios #1718

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix building for ios #1718

merged 1 commit into from
Jul 13, 2021

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Jun 16, 2021

libproc.h is not available on ios, this brings it through the compiler

@m-kuhn m-kuhn changed the title Fix building on ios Fix building for ios Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1718 (5aafb35) into main (19000cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         151      151           
  Lines       20761    20761           
=======================================
  Hits        13889    13889           
  Misses       6872     6872           
Impacted Files Coverage Δ
src/futils.cpp 87.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19000cd...5aafb35. Read the comment docs.

@hassec hassec added architecture platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc and removed architecture labels Jun 21, 2021
Copy link
Collaborator

@kevinbackhouse kevinbackhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to test this on iOS, but it doesn't affect any of the other platforms so I think it is fine to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants