Fix build with gtest 1.11 #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INSTANTIATE_TYPED_TEST_CASE_P requires a non-empty prefix now
Codecov Report
@@ Coverage Diff @@
## main #1722 +/- ##
=======================================
Coverage 66.89% 66.89%
=======================================
Files 151 151
Lines 20761 20761
=======================================
Hits 13889 13889
Misses 6872 6872
Continue to review full report at Codecov.
|
|
Thanks, worked great here too for Gentoo. |
hassec
approved these changes
Jun 20, 2021
There was a problem hiding this comment.
@antonio-rojas thanks a lot for taking the time to contribute this fix! 👍
|
@Mergifyio backport 0.27-maintenance |
|
Command
|
hassec
added a commit
that referenced
this pull request
Jun 21, 2021
fix: build with gtest 1.11 (backport #1722)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTANTIATE_TYPED_TEST_CASE_P requires a non-empty prefix now