Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero initialize local variables. #1743

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Conversation

kevinbackhouse
Copy link
Collaborator

Rebase of #1737 onto main. (Doing this manually because #1742 had some merge conflicts.)

@kevinbackhouse kevinbackhouse changed the title Initialize locals Zero initialize local variables. Jun 26, 2021
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #1743 (b235eaf) into main (fe83c73) will increase coverage by 0.00%.
The diff coverage is 73.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1743   +/-   ##
=======================================
  Coverage   66.89%   66.90%           
=======================================
  Files         151      151           
  Lines       20754    20786   +32     
=======================================
+ Hits        13883    13906   +23     
- Misses       6871     6880    +9     
Impacted Files Coverage Δ
samples/Jzon.cpp 33.39% <0.00%> (-0.18%) ⬇️
src/http.cpp 0.00% <0.00%> (ø)
src/preview.cpp 57.46% <0.00%> (-0.29%) ⬇️
src/webpimage.cpp 64.97% <0.00%> (-0.17%) ⬇️
src/pgfimage.cpp 55.93% <50.00%> (-0.11%) ⬇️
src/image.cpp 72.51% <66.66%> (-0.05%) ⬇️
include/exiv2/types.hpp 90.90% <100.00%> (ø)
include/exiv2/value.hpp 90.62% <100.00%> (ø)
samples/geotag.cpp 79.36% <100.00%> (+0.27%) ⬆️
samples/largeiptc-test.cpp 79.06% <100.00%> (+1.02%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83c73...b235eaf. Read the comment docs.

Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks a lot @kevinbackhouse for the quick rebase :)

@hassec hassec merged commit 2b84f4b into Exiv2:main Jun 27, 2021
@hassec hassec added this to the v1.00 milestone Jun 27, 2021
@hassec hassec added refactoring Cleanup / Simplify code -> more readable / robust bug labels Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants