Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid processing MOV (quicktime) files when BMFF is enabled (backport #1745) #1774

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 12, 2021

This is an automatic backport of pull request #1745 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot assigned hassec Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1774 (3e681c6) into main (9284b58) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   67.36%   67.36%           
=======================================
  Files         151      151           
  Lines       20802    20803    +1     
=======================================
+ Hits        14013    14014    +1     
  Misses       6789     6789           
Impacted Files Coverage Δ
src/bmffimage.cpp 81.36% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9284b58...3e681c6. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 1 alert when merging 3e681c6 into 9284b58 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

@hassec hassec removed their assignment Jul 12, 2021
Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should probably be approved by someone else

@kevinbackhouse kevinbackhouse merged commit 6798be6 into main Jul 13, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1745 branch July 13, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants