Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonyMisc3c makernote tags (tag 9400) #1800

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

postscript-dev
Copy link
Collaborator

@postscript-dev postscript-dev commented Jul 26, 2021

Changes:

  • Add tags. Rename Exiftool's SequenceLength tags to SequenceLength1
    and SequenceLength2, to prevent a name clash
  • Update docs and manpage
  • Add testing, including 2 EXV files extracted from Exiftool's Sony image
    samples (https://exiftool.org/sample_images.html)

Source: Exiftool

Changes:
+ Add tags. Rename Exiftool `SequenceLength` tags to `SequenceLength1`
  and `SequenceLength2`, to prevent a name clash.
+ Update docs and manpage.

Source: [Exiftool](https://exiftool.org)
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1800 (a82b6ce) into main (c474277) will increase coverage by 0.33%.
The diff coverage is 67.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   67.52%   67.85%   +0.33%     
==========================================
  Files         151      151              
  Lines       20901    20932      +31     
==========================================
+ Hits        14113    14204      +91     
+ Misses       6788     6728      -60     
Impacted Files Coverage Δ
src/makernote_int.hpp 91.66% <ø> (ø)
src/tags_int.cpp 87.20% <ø> (ø)
src/tags_int.hpp 90.90% <ø> (ø)
src/tiffimage_int.cpp 89.28% <ø> (ø)
src/sonymn_int.cpp 68.98% <62.66%> (-4.24%) ⬇️
src/makernote_int.cpp 80.52% <100.00%> (+0.47%) ⬆️
src/iptc.cpp 75.72% <0.00%> (-0.34%) ⬇️
src/version.cpp 91.51% <0.00%> (-0.21%) ⬇️
src/image.cpp 72.74% <0.00%> (-0.17%) ⬇️
src/exiv2app.hpp 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c474277...a82b6ce. Read the comment docs.

@postscript-dev postscript-dev changed the title WIP: Add SonyMisc3c makernote tags (tag 9400) Add SonyMisc3c makernote tags (tag 9400) Jul 26, 2021
kevinbackhouse
kevinbackhouse previously approved these changes Jul 26, 2021
@postscript-dev
Copy link
Collaborator Author

Thanks @kevinbackhouse for looking at this and the other PRs that you have checked.

@kevinbackhouse
Copy link
Collaborator

@postscript-dev: No problem! Just be aware that I know absolutely nothing about cameras! I'm just checking that the C++ looks correct.

@kevinbackhouse kevinbackhouse merged commit 22b876d into Exiv2:main Jul 28, 2021
@postscript-dev postscript-dev deleted the add_SonyMisc3c_tags branch October 20, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants