Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assertion with an error message (backport #1834) #1836

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 3, 2021

This is an automatic backport of pull request #1834 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1836 (50bc3c5) into main (d3e311f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 50bc3c5 differs from pull request most recent head e34e150. Consider uploading reports for the commit e34e150 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
- Coverage   60.59%   60.58%   -0.01%     
==========================================
  Files          96       96              
  Lines       18860    18864       +4     
  Branches     9479     9483       +4     
==========================================
+ Hits        11428    11429       +1     
- Misses       5142     5146       +4     
+ Partials     2290     2289       -1     
Impacted Files Coverage Δ
src/tiffcomposite_int.cpp 73.93% <0.00%> (-0.31%) ⬇️
src/jpgimage.cpp 70.15% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e311f...e34e150. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 47de70b into main Aug 3, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1834 branch August 3, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants