Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assertion with an error message #1848

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: #1847

This assertion is checking a property that, as far as I can tell, isn't enforced anywhere. Nothing bad happens in a release build with assertions switched off, so I think the best solution is to replace the assertion with an error message.

As I mentioned in #1847, I am only able to reproduce this with the fuzzer, which means that the test that I have added isn't a proper regression test. So the main purpose of adding a test is to add the poc to our fuzzing corpus.

@kevinbackhouse kevinbackhouse added bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify labels Aug 5, 2021
@kevinbackhouse kevinbackhouse added this to the v0.27.5 milestone Aug 5, 2021
@kevinbackhouse kevinbackhouse linked an issue Aug 5, 2021 that may be closed by this pull request
@kevinbackhouse kevinbackhouse merged commit 7070063 into Exiv2:0.27-maintenance Aug 5, 2021
kevinbackhouse added a commit that referenced this pull request Aug 6, 2021
Replace assertion with an error message (backport #1848)
@clanmills clanmills mentioned this pull request Aug 9, 2021
@kevinbackhouse kevinbackhouse deleted the FixIssue1847 branch August 11, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failure in TiffDirectory::doWriteImage
2 participants