Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonyMisc(2b|3c) Groups for Sony TIFF files #1922

Merged
merged 2 commits into from
Sep 25, 2021

Conversation

postscript-dev
Copy link
Collaborator

  • Groups now support JPEG and TIFF formats
  • Add regression testing

- Previous version only supported JPEGs.
- Update Python test to use more specific grep, as this prevents
  SonyMisc(2b|3c) from being included. Regression test to be added
  in a different commit.
@postscript-dev postscript-dev added bug makerNote Anything related to one of the various supported MakerNote formats labels Sep 23, 2021
@postscript-dev postscript-dev self-assigned this Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1922 (827f31a) into main (7d2eb4a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   61.13%   61.13%   -0.01%     
==========================================
  Files          96       96              
  Lines       19051    19059       +8     
  Branches     9729     9735       +6     
==========================================
+ Hits        11647    11651       +4     
- Misses       5090     5092       +2     
- Partials     2314     2316       +2     
Impacted Files Coverage Δ
src/makernote_int.cpp 67.62% <50.00%> (-0.72%) ⬇️
src/sonymn_int.cpp 52.76% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2eb4a...827f31a. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit b27aa0b into Exiv2:main Sep 25, 2021
@postscript-dev postscript-dev deleted the fix_sony_tags branch October 20, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug makerNote Anything related to one of the various supported MakerNote formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants