-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS build failure #1962
Fix macOS build failure #1962
Conversation
This reverts commit e667346.
Codecov Report
@@ Coverage Diff @@
## main #1962 +/- ##
=======================================
Coverage 61.12% 61.12%
=======================================
Files 96 96
Lines 19055 19055
Branches 9743 9743
=======================================
Hits 11647 11647
Misses 5092 5092
Partials 2316 2316 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 0.27-maintenance |
✅ Backports have been created
|
Fix macOS build failure (backport #1962)
Builds have started failing on macOS. See for example #1958.
This problem originally only affected Macs with the M1 chip, but I guess it has now spread to the Intel machines too.
This commit reverts #1857, which limited the workaround to just M1 machines. I think we need to go back to applying the workaround to all Macs.