Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS build failure #1962

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

kevinbackhouse
Copy link
Collaborator

Builds have started failing on macOS. See for example #1958.

This problem originally only affected Macs with the M1 chip, but I guess it has now spread to the Intel machines too.

This commit reverts #1857, which limited the workaround to just M1 machines. I think we need to go back to applying the workaround to all Macs.

This reverts commit e667346.
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1962 (532ed8c) into main (4901c5d) will not change coverage.
The diff coverage is n/a.

❗ Current head 532ed8c differs from pull request most recent head cf6566b. Consider uploading reports for the commit cf6566b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1962   +/-   ##
=======================================
  Coverage   61.12%   61.12%           
=======================================
  Files          96       96           
  Lines       19055    19055           
  Branches     9743     9743           
=======================================
  Hits        11647    11647           
  Misses       5092     5092           
  Partials     2316     2316           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4901c5d...cf6566b. Read the comment docs.

cmake/compilerFlags.cmake Outdated Show resolved Hide resolved
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbackhouse kevinbackhouse merged commit 5c701e5 into Exiv2:main Oct 15, 2021
@kevinbackhouse kevinbackhouse deleted the Revert1857 branch October 15, 2021 20:40
@kevinbackhouse
Copy link
Collaborator Author

@Mergifyio backport 0.27-maintenance

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2021

backport 0.27-maintenance

✅ Backports have been created

@kevinbackhouse kevinbackhouse added build CI Issues related with CI jobs labels Oct 17, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Oct 17, 2021
@kevinbackhouse kevinbackhouse added the CMake Configuration issues related with CMake label Oct 17, 2021
clanmills added a commit that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI Issues related with CI jobs CMake Configuration issues related with CMake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants