Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include expat.h when XMP is enabled. (backport #1972) #1973

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2021

This is an automatic backport of pull request #1972 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1973 (a6f1013) into main (b385f2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1973   +/-   ##
=======================================
  Coverage   61.28%   61.28%           
=======================================
  Files          96       96           
  Lines       19079    19079           
  Branches     9748     9748           
=======================================
  Hits        11692    11692           
  Misses       5069     5069           
  Partials     2318     2318           
Impacted Files Coverage Δ
src/xmp.cpp 76.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b385f2d...a6f1013. Read the comment docs.

@kevinbackhouse kevinbackhouse linked an issue Oct 19, 2021 that may be closed by this pull request
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Oct 19, 2021
@kmilos kmilos merged commit 2d80891 into main Oct 20, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1972 branch October 20, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXIV2_ENABLE_XMP=Off incorrectly uses #include <expat.h>
2 participants