Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera models for NikonFl3 makernotes group #1994

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

postscript-dev
Copy link
Collaborator

@postscript-dev postscript-dev commented Nov 8, 2021

According to ExifTool's Nikon.pm file, the NikonFl3 group can be used with NikonFl identifiers 0103, 0104 and 0105.

The test images are from ExifTool's JPEG samples.

Source: ExifTool.

@postscript-dev postscript-dev added enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats labels Nov 8, 2021
@postscript-dev postscript-dev added this to the v1.00 milestone Nov 8, 2021
@postscript-dev postscript-dev self-assigned this Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #1994 (02fa8e6) into main (7c8e6fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1994   +/-   ##
=======================================
  Coverage   61.19%   61.19%           
=======================================
  Files          96       96           
  Lines       19269    19269           
  Branches     9862     9862           
=======================================
  Hits        11791    11791           
  Misses       5135     5135           
  Partials     2343     2343           
Impacted Files Coverage Δ
src/makernote_int.cpp 67.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8e6fc...02fa8e6. Read the comment docs.

@postscript-dev postscript-dev changed the title Add camera models for NikonFl3 Add camera models for NikonFl3 makernotes group Nov 8, 2021
@postscript-dev postscript-dev marked this pull request as ready for review November 8, 2021 11:08
@postscript-dev
Copy link
Collaborator Author

Thanks Kevin.

@kmilos kmilos merged commit 1ae9f42 into Exiv2:main Nov 8, 2021
@postscript-dev postscript-dev deleted the add_models_to_NikonFl3 branch January 9, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants