-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.27 Nightly pre-builds for 0.27 #2025
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #2025 +/- ##
====================================================
- Coverage 58.89% 58.72% -0.18%
====================================================
Files 146 146
Lines 23002 23010 +8
Branches 11809 12599 +790
====================================================
- Hits 13548 13513 -35
- Misses 6688 6690 +2
- Partials 2766 2807 +41
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to replace -t
with --target
. I didn't know what -t
did!
You shouldn't need the -DCMAKE_CXX_STANDARD=98. I added code to set that if it's not defined. It's odd that I can't find that code. It must have been fix_conan_ci which was not merged.
Can you put that CMakeLists.txt and remove the -DCMAKE_CXX_STANDARD=98
from the cmake commands.
It's something like:
if ( NOT ${CMAKE_CXX_STANDARD})
set (CMAKE_CXX_STANDARD 98)
endif()
Yes, after many years doing DevOps, one of the main lessons learned is to use long-name arguments for the pipelines. It helps greatly to the code readability.
Sure, I will place it in |
This pull request fixes 3 alerts when merging 93d7cb4 into afee6cc - view on LGTM.com fixed alerts:
|
* ci: upgrade conan to 1.43, make sure we use CXX_STANDARD 98 * ci: 0.27-nightly pre-releases * cmake: if CMAKE_CXX_STANDARD is not specified => use 98
This PR has been created to demonstrate that the 0.27 automatic release builds do not contain the GTest dlls mentioned in #1984.
I think those DLLs are not appearing anymore in the release packages after we merged #2018. By changing this line in the conan file:
We are now using the STATIC version of GTest and therefore we do not need to copy DLLs around.
Anyways, I think it is useful to also have pre-release packages for 0.27 so that we can check easily if the different packages look good before creating a final release.
Please let me know if this has been already discussed and disabled intentionally in the past.