Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.27 Nightly pre-builds for 0.27 #2025

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Conversation

piponazo
Copy link
Collaborator

This PR has been created to demonstrate that the 0.27 automatic release builds do not contain the GTest dlls mentioned in #1984.

I think those DLLs are not appearing anymore in the release packages after we merged #2018. By changing this line in the conan file:

        self.options['gtest'].shared = False

We are now using the STATIC version of GTest and therefore we do not need to copy DLLs around.

Anyways, I think it is useful to also have pre-release packages for 0.27 so that we can check easily if the different packages look good before creating a final release.
Please let me know if this has been already discussed and disabled intentionally in the past.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #2025 (93d7cb4) into 0.27-maintenance (afee6cc) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2025      +/-   ##
====================================================
- Coverage             58.89%   58.72%   -0.18%     
====================================================
  Files                   146      146              
  Lines                 23002    23010       +8     
  Branches              11809    12599     +790     
====================================================
- Hits                  13548    13513      -35     
- Misses                 6688     6690       +2     
- Partials               2766     2807      +41     
Impacted Files Coverage Δ
include/exiv2/xmp_exiv2.hpp 75.00% <0.00%> (-16.67%) ⬇️
src/utils.cpp 29.16% <0.00%> (-12.51%) ⬇️
include/exiv2/basicio.hpp 62.50% <0.00%> (-12.50%) ⬇️
include/exiv2/value.hpp 74.85% <0.00%> (-7.43%) ⬇️
include/exiv2/error.hpp 55.55% <0.00%> (-7.41%) ⬇️
include/exiv2/types.hpp 64.70% <0.00%> (-3.87%) ⬇️
src/getopt.cpp 60.37% <0.00%> (-1.89%) ⬇️
samples/exiv2json.cpp 58.04% <0.00%> (-1.73%) ⬇️
src/tiffcomposite_int.hpp 86.15% <0.00%> (-1.54%) ⬇️
src/mrwimage.cpp 40.00% <0.00%> (-1.34%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afee6cc...93d7cb4. Read the comment docs.

Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to replace -t with --target. I didn't know what -t did!

You shouldn't need the -DCMAKE_CXX_STANDARD=98. I added code to set that if it's not defined. It's odd that I can't find that code. It must have been fix_conan_ci which was not merged.

Can you put that CMakeLists.txt and remove the -DCMAKE_CXX_STANDARD=98 from the cmake commands.

It's something like:

if ( NOT ${CMAKE_CXX_STANDARD}) 
   set (CMAKE_CXX_STANDARD 98)
endif()

@piponazo
Copy link
Collaborator Author

Good idea to replace -t with --target. I didn't know what -t did!

Yes, after many years doing DevOps, one of the main lessons learned is to use long-name arguments for the pipelines. It helps greatly to the code readability.

Can you put that CMakeLists.txt and remove the -DCMAKE_CXX_STANDARD=98 from the cmake commands.

Sure, I will place it in cmake/mainSetup.cmake.

@lgtm-com
Copy link

lgtm-com bot commented Dec 12, 2021

This pull request fixes 3 alerts when merging 93d7cb4 into afee6cc - view on LGTM.com

fixed alerts:

  • 3 for Comparison result is always the same

@piponazo piponazo merged commit a69dc3f into 0.27-maintenance Dec 13, 2021
@piponazo piponazo deleted the 027_release_packages branch December 13, 2021 06:14
@kmilos kmilos added CI Issues related with CI jobs windows Windows Specific issues CMake Configuration issues related with CMake labels Dec 13, 2021
@kevinbackhouse kevinbackhouse added this to the v0.27.6 milestone Nov 23, 2022
antermin pushed a commit to antermin/exiv2 that referenced this pull request Mar 16, 2023
* ci: upgrade conan to 1.43, make sure we use CXX_STANDARD 98

* ci: 0.27-nightly pre-releases

* cmake: if CMAKE_CXX_STANDARD is not specified => use 98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues related with CI jobs CMake Configuration issues related with CMake windows Windows Specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants