Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in loop. It wasn't iterating over the elements of dateStrings as intended #2037

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Fix bug in loop. It wasn't iterating over the elements of dateStrings as intended #2037

merged 1 commit into from
Dec 20, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: #2036

@kevinbackhouse kevinbackhouse added bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify labels Dec 20, 2021
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2037 (89e50e5) into 0.27-maintenance (6833eca) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 89e50e5 differs from pull request most recent head 15f6a2c. Consider uploading reports for the commit 15f6a2c to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           0.27-maintenance    #2037   +/-   ##
=================================================
  Coverage             58.74%   58.74%           
=================================================
  Files                   146      146           
  Lines                 23004    23003    -1     
  Branches              12596    12596           
=================================================
  Hits                  13513    13513           
+ Misses                 6689     6688    -1     
  Partials               2802     2802
Impacted Files Coverage Δ
samples/geotag.cpp 69.30% <50.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6833eca...15f6a2c. Read the comment docs.

clanmills
clanmills approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thanks.

hassec
hassec approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevinbackhouse kevinbackhouse merged commit a6e0319 into Exiv2:0.27-maintenance Dec 20, 2021
@mergify mergify bot mentioned this pull request Dec 20, 2021
Merged
@kevinbackhouse kevinbackhouse linked an issue Dec 21, 2021 that may be closed by this pull request
out-of-bounds read in geotag #2036
Closed
@kevinbackhouse kevinbackhouse added this to the v0.27.6 milestone Dec 21, 2021
kevinbackhouse added a commit that referenced this pull request Dec 22, 2021
@kevinbackhouse
Merge pull request #2039 from Exiv2/mergify/bp/main/pr-2037
c28e501 
Fix bug in loop. It wasn't iterating over the elements of dateStrings as intended (backport #2037)
@nehaljwani nehaljwani mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clanmills clanmills clanmills approved these changes

@hassec hassec hassec approved these changes

Assignees
No one assigned
Labels
bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify
Projects
None yet
Milestone
v0.27.6
Development

Successfully merging this pull request may close these issues.

out-of-bounds read in geotag
3 participants
@kevinbackhouse @clanmills @hassec