-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_2044_add_tiff_tags #2045
fix_2044_add_tiff_tags #2045
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #2045 +/- ##
=================================================
Coverage 58.72% 58.72%
=================================================
Files 146 146
Lines 23003 23003
Branches 12596 12596
=================================================
Hits 13508 13508
Misses 6692 6692
Partials 2803 2803
Continue to review full report at Codecov.
|
The Windows/CI is broken. I think it needs conan 1.43. I can't submit a change to the PR. Something to do with OAuth. @kmilos Can you submit this for me, please? diff --git a/.github/workflows/on_PR_windows_matrix.yml b/.github/workflows/on_PR_windows_matrix.yml
index 05e88cd..20e38e5 100644
--- a/.github/workflows/on_PR_windows_matrix.yml
+++ b/.github/workflows/on_PR_windows_matrix.yml
@@ -46,7 +46,7 @@ jobs:
- name: Install Conan & Common config
run: |
- pip.exe install "conan==1.39.0"
+ pip.exe install "conan==1.43.0"
conan config install https://github.com/conan-io/conanclientcert.git
conan profile new --detect default
conan profile update settings.build_type=${{matrix.build_type}} default |
Will do as soon as I get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kmilos Thanks for fixing this, Miloš. I don't know why I can't update a PR that I created. Grrrrr. Git. Happy New Year. Best Wishes for 2022. This will be my last year of contributing to Exiv2. I really hope to see the project moving smoothly into the future. I've got to stop pushing, retire and leave it alone. What will be will be. |
Same to you Robin, I hope you properly enjoy your retirement this year! |
Not only will I enjoy my retirement, I'm sure most of the team will be pleased when I am not snooping around. It's time for me to let go. And for sure, I cannot do anything that you guys cannot do. @nehaljwani is doing some excellent release engineering work. |
See #2044