Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_2044_add_tiff_tags #2045

Merged
merged 2 commits into from
Jan 2, 2022
Merged

fix_2044_add_tiff_tags #2045

merged 2 commits into from
Jan 2, 2022

Conversation

clanmills
Copy link
Collaborator

See #2044

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #2045 (1f3ad27) into 0.27-maintenance (1605fe5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           0.27-maintenance    #2045   +/-   ##
=================================================
  Coverage             58.72%   58.72%           
=================================================
  Files                   146      146           
  Lines                 23003    23003           
  Branches              12596    12596           
=================================================
  Hits                  13508    13508           
  Misses                 6692     6692           
  Partials               2803     2803           
Impacted Files Coverage Δ
src/tags_int.cpp 77.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1605fe5...1f3ad27. Read the comment docs.

@clanmills
Copy link
Collaborator Author

The Windows/CI is broken. I think it needs conan 1.43. I can't submit a change to the PR. Something to do with OAuth. @kmilos Can you submit this for me, please?

diff --git a/.github/workflows/on_PR_windows_matrix.yml b/.github/workflows/on_PR_windows_matrix.yml
index 05e88cd..20e38e5 100644
--- a/.github/workflows/on_PR_windows_matrix.yml
+++ b/.github/workflows/on_PR_windows_matrix.yml
@@ -46,7 +46,7 @@ jobs:
 
       - name: Install Conan & Common config
         run: |
-          pip.exe install "conan==1.39.0"
+          pip.exe install "conan==1.43.0"
           conan config install https://github.com/conan-io/conanclientcert.git
           conan profile new --detect default
           conan profile update settings.build_type=${{matrix.build_type}} default

@kmilos
Copy link
Collaborator

kmilos commented Jan 2, 2022

Will do as soon as I get a chance

Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clanmills
Copy link
Collaborator Author

@kmilos Thanks for fixing this, Miloš. I don't know why I can't update a PR that I created. Grrrrr. Git.

Happy New Year. Best Wishes for 2022. This will be my last year of contributing to Exiv2. I really hope to see the project moving smoothly into the future. I've got to stop pushing, retire and leave it alone. What will be will be.

@clanmills clanmills merged commit 7f50d14 into 0.27-maintenance Jan 2, 2022
@clanmills clanmills deleted the fix_2044_add_tiff_tags branch January 2, 2022 21:39
@kmilos
Copy link
Collaborator

kmilos commented Jan 2, 2022

Same to you Robin, I hope you properly enjoy your retirement this year!

@clanmills
Copy link
Collaborator Author

Not only will I enjoy my retirement, I'm sure most of the team will be pleased when I am not snooping around. It's time for me to let go. And for sure, I cannot do anything that you guys cannot do. @nehaljwani is doing some excellent release engineering work.

@kmilos kmilos added this to the v0.27.6 milestone Jan 3, 2022
@kmilos kmilos added the bug label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

According to release notes of 0.27.5 #1765 was included but it's not
2 participants