Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sigma 12-24mm F4 DG HSM Art lens for Nikon #2069

Merged
merged 2 commits into from
Feb 5, 2022

Conversation

Sturmflut
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #2069 (4eac841) into main (ed09d9f) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
- Coverage   62.04%   61.83%   -0.22%     
==========================================
  Files          96       96              
  Lines       19194    19100      -94     
  Branches     9833     9817      -16     
==========================================
- Hits        11909    11810      -99     
- Misses       4978     4995      +17     
+ Partials     2307     2295      -12     
Impacted Files Coverage Δ
src/nikonmn_int.cpp 46.76% <ø> (ø)
src/safe_op.hpp 69.23% <0.00%> (-27.65%) ⬇️
include/exiv2/slice.hpp 69.64% <0.00%> (-21.89%) ⬇️
include/exiv2/error.hpp 60.71% <0.00%> (-4.81%) ⬇️
src/utils.cpp 38.46% <0.00%> (-1.93%) ⬇️
include/exiv2/value.hpp 82.96% <0.00%> (-0.55%) ⬇️
src/enforce.hpp 75.00% <0.00%> (+2.77%) ⬆️
src/getopt.cpp 67.30% <0.00%> (+5.76%) ⬆️
include/exiv2/metadatum.hpp 88.88% <0.00%> (+16.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed09d9f...4eac841. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@piponazo piponazo merged commit fde0f9e into Exiv2:main Feb 5, 2022
@Sturmflut Sturmflut deleted the sigma-12-24mm-f4-dg-hsm-art branch February 5, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants