Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Delete dead code" #2078

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Revert "Delete dead code" #2078

merged 1 commit into from
Feb 8, 2022

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Feb 8, 2022

This reverts commit 1d6bac6.

As discussed in the commit, @mallman is using this functionality in his library.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2078 (1f07715) into main (275bcb9) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
- Coverage   62.09%   61.87%   -0.23%     
==========================================
  Files          96       96              
  Lines       19149    19059      -90     
  Branches     9798     9782      -16     
==========================================
- Hits        11891    11792      -99     
- Misses       4963     4984      +21     
+ Partials     2295     2283      -12     
Impacted Files Coverage Δ
include/exiv2/datasets.hpp 100.00% <ø> (ø)
src/datasets.cpp 93.03% <0.00%> (-2.42%) ⬇️
src/safe_op.hpp 69.23% <0.00%> (-27.65%) ⬇️
include/exiv2/slice.hpp 69.64% <0.00%> (-21.89%) ⬇️
include/exiv2/error.hpp 60.71% <0.00%> (-4.81%) ⬇️
src/utils.cpp 38.46% <0.00%> (-1.93%) ⬇️
include/exiv2/value.hpp 82.68% <0.00%> (-0.56%) ⬇️
src/enforce.hpp 75.00% <0.00%> (+2.77%) ⬆️
src/getopt.cpp 67.30% <0.00%> (+5.76%) ⬆️
include/exiv2/metadatum.hpp 88.88% <0.00%> (+16.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275bcb9...1f07715. Read the comment docs.

@piponazo piponazo merged commit 4ae42b1 into main Feb 8, 2022
@piponazo piponazo deleted the main_recoverDatasetLists branch February 8, 2022 12:31
@piponazo
Copy link
Collaborator Author

Thanks @jim-easterbrook for pointing out. As you can see, I have opened a PR for recovering that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants