Refactoring & cleanup #2109
Merged
Refactoring & cleanup #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to have an important impact in performance. The execution of ctest on Windows passed from 48.5 secs to 43.8. Check if this is the same on Linux
piponazo
commented
Feb 18, 2022
piponazo
commented
Feb 18, 2022
| @@ -278,6 +284,7 @@ namespace Exiv2 { | |||
| return Image::byteSwap(v,bSwap); | |||
| } | |||
|
|
|||
| /// \todo not used internally. At least we should test it | |||
There was a problem hiding this comment.
I added these comments in few places because cppcheck was detecting these functions as UNUSED ones. However they are part of the API and they should not be removed without further consideration.
piponazo
force-pushed
the
main_StringView
branch
from
6076baa
to
f774a3b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
+ Coverage 63.80% 63.98% +0.18%
==========================================
Files 96 97 +1
Lines 19169 19086 -83
Branches 9772 9752 -20
==========================================
- Hits 12230 12212 -18
+ Misses 4658 4599 -59
+ Partials 2281 2275 -6
Continue to review full report at Codecov.
|
neheb
reviewed
Feb 19, 2022
neheb
reviewed
Feb 19, 2022
neheb
reviewed
Feb 19, 2022
neheb
reviewed
Feb 19, 2022
piponazo
force-pushed
the
main_StringView
branch
from
8b86150
to
21eb0ce
Compare
neheb
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it goes a bunch of totally unrelated changes with the aim of simplifying code and removing some dead code (take a look to the LoC deletions 😨 ). In case it is difficult to review so many changes, I can split the PR in few ones by different topics. Although I tried to keep different changes in isolated commits.
This is a list of the different actions taken here:
string_viewin some more places.