Fix test_pr_1905.py for native 2019msvc64 (#2108)

[postscript-dev]

Closes #2108.

[piponazo]

Tested on my Windows PC and it works 👏

[clanmills]

Beautiful fix, @postscript-dev.

[codecov]

Codecov Report

Merging #2112 (4a6d44a) into main (5d86044) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2112   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files          96       96           
  Lines       19171    19171           
  Branches     9772     9772           
=======================================
  Hits        12232    12232           
  Misses       4658     4658           
  Partials     2281     2281           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d86044...4a6d44a. Read the comment docs.

[postscript-dev]

@piponazo:
Thanks for the quick response!

Last year, I noticed a problem related to this issue that I think is worth mentioning.

The Exiv2 mechanism to create tag webpages from the source code is only run when we publish the website. This means that when we make changes, the CI will not catch any errors for us. To create the webpages is simple.

1. Set the EXIV2HOME environment variable (e.g., /home/postscript-dev/exiv2_postscript-dev)
2. In the doc/templates directory, run make

The build instructions are missing from README.md but I plan to add them.

If you have the time, could you look at the CI?

[hassec]

Can we keep test/data for input data and use test/data/test_reference_files for reference output?

[piponazo]

Can we keep test/data for input data and use test/data/test_reference_files for reference output?

I think it would be a good idea to write this down in the wiki or in the test/README document to give instructions to people about some of the practices we have been discussing lately about writting tests.

The Exiv2 mechanism to create tag webpages from the source code is only run when we publish the website. This means that when we make changes, the CI will not catch any errors for us. To create the webpages is simple.

@postscript-dev whenever you create the PR with the instructions, please do it in the main repository and I'll happily try to adapt our CI jobs to make this run on every PR.